Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alwayslink=True Bazel flag #4396

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

mering
Copy link
Contributor

@mering mering commented Jun 11, 2024

Remove the alwayslink=True flag from BUILD:bazel.

This should have no effect for header only libraries as mentioned in googleapis/google-cloud-cpp#14310 (comment).

@mering mering requested a review from nlohmann as a code owner June 11, 2024 08:44
@github-actions github-actions bot added the S label Jun 11, 2024
@mering mering changed the title Remove alwayslink=True flag Remove alwayslink=True Bazel flag Jun 11, 2024
@nlohmann nlohmann added this to the Release 3.11.4 milestone Nov 16, 2024
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann merged commit e509007 into nlohmann:develop Nov 16, 2024
3 checks passed
@nlohmann
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants