Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPack support #4459

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Add CPack support #4459

merged 1 commit into from
Nov 16, 2024

Conversation

zjyhjqs
Copy link
Contributor

@zjyhjqs zjyhjqs commented Sep 17, 2024

No description provided.

Copy link

request-info bot commented Sep 17, 2024

We would appreciate it if you could provide us with more info about this issue or pull request! Please check the issue template and the pull request template.

@request-info request-info bot added the state: needs more info the author of the issue needs to provide more details label Sep 17, 2024
@zjyhjqs
Copy link
Contributor Author

zjyhjqs commented Nov 14, 2024

@nlohmann Do you have question about this PR?

@nlohmann
Copy link
Owner

@nlohmann Do you have question about this PR?

Why is this addition needed?

@zjyhjqs
Copy link
Contributor Author

zjyhjqs commented Nov 15, 2024

Why is this addition needed?

The CPack module is necessary for users to use CPack to package the library. (The main information required by cpack is provided by project(). Just including the CPack module is enough.)

Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.4 milestone Nov 16, 2024
@nlohmann nlohmann merged commit fd20975 into nlohmann:develop Nov 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake S state: needs more info the author of the issue needs to provide more details
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants