Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TurpentineDistillery feature/locale independent str to num #450

Merged
merged 27 commits into from
Feb 14, 2017
Merged

TurpentineDistillery feature/locale independent str to num #450

merged 27 commits into from
Feb 14, 2017

Conversation

nlohmann
Copy link
Owner

overworked #379

Alex Astashyn and others added 27 commits December 3, 2016 19:05
Added strtonum for locale-independent number parsing
6b78b5c
Improved overflow detection; removed debugging output statements.
4eafaab
stylistic changes
c75efed
Alternative handling of integer types relying on strto[u]ll
e41a956
Bugfix: when working with C formatting functions we need to query C l…
d643360 
…ocales (localeconv) rather than std::locale
Refactored preprocessing with a lambda instead of do{...}while(0)
0c87d5d
Refactored preprocessing with a lambda instead of do{...}while(0)
7a08124
Added unit-test for issue #379 (locale-independent str-to-num)
6e8da7d
Trying to coerce setlocale to make snprintf use commas as delimiter; …
d2e9ce2 
…the behavior appears to be compiler/platform-specific
simplified code a bit based on @gregmarr's suggestions
d169598
Trying to coerce setlocale to make snprintf use commas as delimiter s…
6774457 
…ome more
Refactored to avoid using exceptions, as there are plans to support e…
0a4a6a8 
…xceptionless mode
Tweaks to unit-test for issue #379
27d9740
Removed unused struct; fixed comments
38499e8
Still trying to invoke locale-specific behavior in CI
1c029b9
Tweaked check for preserved sign; added LCOV_EXCL_LINE
cd0b651
Disabling strtod pre-check, since can't get locale-specific behavior …
0f8de48 
…to manifest in AppVeyor
Tweaked check for preserved sign; added LCOV_EXCL_LINE
5cad200
Merged upstream/develop into feature/locale_independent_str_to_num
6fba52b
Merge upstream/develop into feature/locale_independent_str_to_num
c236b59
@nlohmann
🔀 merged #379 and fixed conflicts
8d88a1d
@nlohmann
🔀 merge branch 'develop' into TurpentineDistillery-feature/locale_ind…
926af6d 
…ependent_str_to_num
@nlohmann
💄 cleanup
9f5dccb
@nlohmann
🔨 make lexer distinguishes number types
c2d5510
@nlohmann
🔨 further cleanup
c8191c8
@nlohmann
✅ improved test coverage
b84705d
@nlohmann
🔨 more work on the number parser
265c5b5
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 99.964% when pulling 265c5b5 on TurpentineDistillery-feature/locale_independent_str_to_num into c95ff86 on develop.

@nlohmann
Copy link
Owner Author

closes #379 and #302

@nlohmann nlohmann closed this Feb 14, 2017
@nlohmann nlohmann deleted the TurpentineDistillery-feature/locale_independent_str_to_num branch February 14, 2017 06:16
This was referenced Feb 14, 2017
Closed
Closed
@nlohmann nlohmann self-assigned this Feb 14, 2017
@nlohmann nlohmann added this to the Release 2.1.1 milestone Feb 14, 2017
@nlohmann nlohmann restored the TurpentineDistillery-feature/locale_independent_str_to_num branch February 14, 2017 06:18
@nlohmann nlohmann reopened this Feb 14, 2017
@nlohmann nlohmann merged commit 22b9a30 into develop Feb 14, 2017
@nlohmann nlohmann deleted the TurpentineDistillery-feature/locale_independent_str_to_num branch February 14, 2017 06:18
@nlohmann nlohmann mentioned this pull request Feb 15, 2017
Closed
@tfussell tfussell mentioned this pull request Nov 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
None yet
Projects
None yet
Milestone
Release 2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nlohmann @coveralls