Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update json.hpp #686

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Update json.hpp #686

merged 1 commit into from
Aug 10, 2017

Conversation

GoWebProd
Copy link
Contributor

mistake

Update json.hpp
c9509cc 
mistake
nlohmann
nlohmann approved these changes Aug 9, 2017
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann
Copy link
Owner

nlohmann commented Aug 9, 2017

Wow. That's a subtle, yet blatant error...

@nlohmann nlohmann self-assigned this Aug 9, 2017
@nlohmann nlohmann added kind: bug solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels Aug 9, 2017
@nlohmann nlohmann added this to the Release 3.0.0 milestone Aug 9, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c9509cc on WebProdPP:patch-1 into 6e5b895 on nlohmann:develop.

@nlohmann nlohmann merged commit d26b3f1 into nlohmann:develop Aug 10, 2017
@nlohmann
Copy link
Owner

Thanks!

nlohmann added a commit that referenced this pull request Aug 10, 2017
@nlohmann
📝 acknowledgements for #674, #678, #682, #685, and #686
99ea12f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

@nlohmann nlohmann

Labels
kind: bug solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GoWebProd @nlohmann @coveralls