Overworked library toward 3.0.0 release #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All hex literals use upper case letters after the x. - Fixed sime typos. - Documented some more functions.
- Added recent contributors to thanks list. - Linked PGP key for private mails. - Updated compiler list.
Update required all CHECK_THROWS_AS macros to pass the exception type without reference, because this is now done by Catch2.
gregmarr
reviewed
Dec 13, 2017
README.md
Outdated
|
|
||
| ## Contact | ||
|
|
||
| If you have questions regarding the library, I would like to invite you to [open an issue at Github](https://github.com/nlohmann/json/issues/new). Please describe your request, problem, or question as detailed as possible, and also mention the version of the library you are using as well as the version of your compiler and operating system. Opening an issue at Github allows other users and contributors to this library to collaborate. For instance, I have little experience with MSVC, and most issues in this regard have been solved by a growing community. If you have a look at the [closed issues](https://github.com/nlohmann/json/issues?q=is%3Aissue+is%3Aclosed), you will see that we react quite timely in most cases. | ||
|
|
||
| Only if your request would contain confidential information, please [send me an email](mailto:mail@nlohmann.me). | ||
| Only if your request would contain confidential information, please [send me an email](mailto:mail@nlohmann.me). For encrypted messages, please usse [this key](https://keybase.io/nlohmann/pgp_keys.asc). |
There was a problem hiding this comment.
Thanks. I shall fix this.
|
I noticed that you were cleaning up spaces around the |
|
@gregmarr This is due to Artistic Style which sometimes seems to interpret |
|
Oh, it's an auto formatter? |
|
Yes, see http://astyle.sourceforge.net. I am using it for some years now and have not found an equivalent Clang-format style. "My" style is implemented in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated Catch(version 2.0.1 is slower than the 1.9.x version we use)Pull request checklist