Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impls #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Impls #7

wants to merge 2 commits into from

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Jan 27, 2022

No description provided.

nlordell
nlordell reviewed Feb 19, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 19, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 19, 2022
View reviewed changes
src/impls/scale.rs Outdated Show resolved Hide resolved
@vorot93 vorot93 force-pushed the impls branch 5 times, most recently from 880afb6 to 9a9fd5c Compare February 22, 2022 00:34
@vorot93 vorot93 requested a review from nlordell February 22, 2022 00:36
nlordell
nlordell reviewed Feb 22, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 22, 2022
View reviewed changes
src/impls/serde.rs Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 22, 2022
View reviewed changes
src/impls/serde.rs Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 22, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 22, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 22, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
nlordell
nlordell reviewed Feb 22, 2022
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@albttx
Copy link

albttx commented Mar 24, 2022

Hello, any update on this ? i really need the serialize / deserialize feature :) (I'm new with rust, still hard for me to implement :/ )

@nlordell nlordell mentioned this pull request May 6, 2022
Merged
@nlordell
Copy link
Owner

nlordell commented May 6, 2022

Hey @albttx - I created a separate PR #15 with just serde support for the crate.

@vorot93
Copy link
Contributor Author

vorot93 commented May 24, 2022

@nlordell I reworked this PR to only include RLP and SCALE impls.

@nlordell
Copy link
Owner

Thanks! I will find some time to review it this week.

@vorot93 vorot93 requested a review from nlordell September 11, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst left review comments

@nlordell nlordell Awaiting requested review from nlordell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vorot93 @albttx @nlordell @gakonst