Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make town base scene #64

Closed
3 tasks done
nmkataoka opened this issue Jul 6, 2020 · 0 comments · Fixed by #71
Closed
3 tasks done

Make town base scene #64

nmkataoka opened this issue Jul 6, 2020 · 0 comments · Fixed by #71
Assignees
@nmkataoka
Milestone
Gameplay Loop

Comments

@nmkataoka
Copy link
Owner

nmkataoka commented Jul 6, 2020 •
edited
Loading

Description

Let's create a "town" scene.

Acceptance Criteria

Tasks

Use this section to keep track of work
  • Create a town scene
  • Create a modal component
  • Add several "shops" to the town scene that open up empty modals when clicked on

QA Notes

Environments

Steps
@nmkataoka nmkataoka self-assigned this Jul 6, 2020
@nmkataoka nmkataoka added this to the Gameplay Loop milestone Jul 6, 2020
nmkataoka added a commit that referenced this issue Jul 25, 2020
@nmkataoka
Add town scene [Re #64]
184f734
nmkataoka added a commit that referenced this issue Jul 25, 2020
@nmkataoka
Add modal component [Re: #64]
1d07227 
Had to manually upgrade jest-dom in order for react-testing-library
to work properly. React scripts will be upgrading jest-dom soon in
v4.0.0:
testing-library/dom-testing-library#477
@nmkataoka nmkataoka mentioned this issue Jul 25, 2020
Merged
1 task
nmkataoka added a commit that referenced this issue Jul 25, 2020
@nmkataoka
Add modal z-index behavior, add redux test utils [Re: #64]
5eee486 
Added global redux counter and behavior to ensure active modal is
always brought to the front.

Added a random offset so identical modals don't overlap.

Added a test-utils file that overwrites testing-library/react's render
method to supply a redux store. This should be used for most frontend
rendering tests going forward.
nmkataoka added a commit that referenced this issue Jul 26, 2020
@nmkataoka
Fix build error [Re: #64]
d9b422c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmkataoka nmkataoka

Labels
None yet
Projects
None yet
Milestone
Gameplay Loop
Development

Successfully merging a pull request may close this issue.

Add town scene nmkataoka/adv-life
1 participant
@nmkataoka