Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide backbone-defined valid tags for Attributes #307

Merged
merged 59 commits into from
Dec 5, 2024

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Oct 23, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@sebbi08 sebbi08 added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

@sebbi08
Copy link
Contributor Author

sebbi08 commented Oct 24, 2024

You can already review. The backbone route is not yet finished, so this PR will still be a draft

@Magnus-Kuhn
Copy link
Contributor

Getting the list of valid tags doesn't really require being logged in, on the other hand they're only supposed to be used for attributes which currently can only be shared between Identities. So I think it's ok that they require a login.

But I'd expect that the list is not fetched from the backbone every time you want to do something with a tag (which is often), but rather that the backbone sends the list whenever it is changed (e. g. via an event) and it's then stored locally.

@Magnus-Kuhn Magnus-Kuhn changed the title feat: add usecase for fetching tokens Add UseCase for fetching the list of valid tags from the backbone Oct 24, 2024
@Magnus-Kuhn
Copy link
Contributor

on a second thought: the tag list is only required when creating or receiving an attribute with tags or when changing tags. I'm not sure where this falls regarding storage vs. no storage

@jkoenig134 jkoenig134 removed their request for review October 28, 2024 08:25
@jkoenig134
Copy link
Member

I'll not review a Draft. Please re-assign when finished.

@jkoenig134
Copy link
Member

@sebbi08 sebbi08 removed the wip Work in Progress (blocks mergify from auto update the branch) label Oct 29, 2024
@sebbi08 sebbi08 marked this pull request as ready for review October 29, 2024 13:45
@sebbi08 sebbi08 requested a review from jkoenig134 October 29, 2024 13:52
@sebbi08 sebbi08 force-pushed the feature/retrive_tags_from_backbone branch from 876cf62 to d8f5f70 Compare December 3, 2024 14:05
Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoenig134 Do you want to take another look?

@jkoenig134
Copy link
Member

@sebbi08 now the things in transport are also named AttributeTag* - but transport doesn't know of Attributes, for transport it's just tags.

If that's undone I will do another review.

Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebbi08 sebbi08 enabled auto-merge (squash) December 5, 2024 10:19
@sebbi08 sebbi08 merged commit c285509 into main Dec 5, 2024
19 checks passed
@sebbi08 sebbi08 deleted the feature/retrive_tags_from_backbone branch December 5, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants