Delete obsolete LocalAccounts on App startup #356

Milena-Czierlinski · 2024-12-03T17:05:20Z

Readiness checklist

I added/updated tests.
I ensured that the PR title is good enough for the changelog.
I labeled the PR.
I self-reviewed the PR.

This reverts commit 01813a6.

jkoenig134 · 2024-12-03T17:14:35Z

🔥

packages/app-runtime/src/AppRuntime.ts

packages/runtime/test/transport/account.test.ts

packages/app-runtime/src/multiAccount/MultiAccountController.ts

packages/app-runtime/src/multiAccount/AccountServices.ts

packages/app-runtime/test/runtime/Startup.test.ts

packages/app-runtime/src/AppRuntime.ts

packages/runtime/src/useCases/transport/account/CheckDeletionOfIdentity.ts

…ocal-data-deletion

Milena-Czierlinski added 25 commits November 27, 2024 13:37

feat: add logic to start of runtime

d14a967

feat: add backbone route

8684bc4

refactor: rename checkIdentityDeletionForUsername

5690096

feat: add checkIdentityDeletionForUsername use case

2bedc22

Merge branch 'main' into local-data-deletion

6c5ec80

feat: get username in transport

fc4f3d8

refactor: rename to checkDeletionOfIdentity

5b94813

test: identitycontroller

f0a035f

fix: rename consistently

cfe7f8c

Merge branch 'main' into local-data-deletion

5aac68f

test: add runtime test

fc389f5

feat: continue startApp

0542ab3

Merge remote-tracking branch 'origin/main' into local-data-deletion

14bfbd9

feat: delete accounts if identities are deleted

424d042

feat: bump backbone

b6e06d2

Merge remote-tracking branch 'origin/main' into local-data-deletion

bed355e

fix: provide config for updated backbone

6fa867d

feat: add IdentityDeletionInfo object

01813a6

test: add transport test for passed grace period

9fd7749

refactor: errors

a9c4344

Revert "feat: add IdentityDeletionInfo object"

3970100

This reverts commit 01813a6.

test: add runtime test for expired grace period

314c16c

refactor: naming

61437cd

refactor: rename startAccounts

9b9c651

Merge remote-tracking branch 'origin/main' into local-data-deletion

37f6a17

Milena-Czierlinski added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Dec 3, 2024

Milena-Czierlinski commented Dec 3, 2024

View reviewed changes

packages/app-runtime/src/AppRuntime.ts Outdated Show resolved Hide resolved

jkoenig134 reviewed Dec 3, 2024

View reviewed changes

packages/runtime/test/transport/account.test.ts Outdated Show resolved Hide resolved

test: accounts of deleted identities are remove on app startup

c08f8a0

Milena-Czierlinski commented Dec 13, 2024

View reviewed changes

packages/app-runtime/src/multiAccount/MultiAccountController.ts Outdated Show resolved Hide resolved

Milena-Czierlinski added 4 commits December 13, 2024 12:19

refactor: rename offboardDevice on AccountService

a34d756

feat: add deleteAccount to AccountServices

00df598

fix: app-runtime tests

1581da0

Merge remote-tracking branch 'origin/main' into local-data-deletion

4a48ccf

jkoenig134 reviewed Dec 13, 2024

View reviewed changes

packages/app-runtime/src/multiAccount/AccountServices.ts Show resolved Hide resolved

jkoenig134 reviewed Dec 13, 2024

View reviewed changes

packages/app-runtime/src/multiAccount/AccountServices.ts Outdated Show resolved Hide resolved

refactor: rename offboardAccount

698caf3

Milena-Czierlinski commented Dec 13, 2024

View reviewed changes

packages/app-runtime/test/runtime/Startup.test.ts Outdated Show resolved Hide resolved

jkoenig134 reviewed Dec 13, 2024

View reviewed changes

packages/app-runtime/src/AppRuntime.ts Outdated Show resolved Hide resolved

britsta reviewed Dec 13, 2024

View reviewed changes

packages/runtime/src/useCases/transport/account/CheckDeletionOfIdentity.ts Outdated Show resolved Hide resolved

jkoenig134 and others added 9 commits December 13, 2024 15:05

chore: simplify

1274612

chore: simplify

c5c59e8

Merge branch 'local-data-deletion' of github.com:nmshd/runtime into l…

e095de2

…ocal-data-deletion

refactor: rename checkIfIdentityIsDeleted

7bcd234

test: make tests independent

ea4ec44

test: offboard account of identity with ongoing grace period

ef05861

test: adjust runDeletionJob

77c5815

chore: package-lock

e526ce7

test: rename

1979373

jkoenig134 previously approved these changes Dec 13, 2024

View reviewed changes

jkoenig134 marked this pull request as ready for review December 13, 2024 16:54

fix: make more tests independent

be734fc

Milena-Czierlinski dismissed jkoenig134’s stale review via be734fc December 13, 2024 17:00

jkoenig134 approved these changes Dec 13, 2024

View reviewed changes

Milena-Czierlinski enabled auto-merge (squash) December 13, 2024 17:06

jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Dec 13, 2024

Milena-Czierlinski merged commit e1bd4c7 into main Dec 13, 2024
20 checks passed

Milena-Czierlinski deleted the local-data-deletion branch December 13, 2024 17:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete obsolete LocalAccounts on App startup #356

Delete obsolete LocalAccounts on App startup #356

Milena-Czierlinski commented Dec 3, 2024

jkoenig134 commented Dec 3, 2024

Delete obsolete LocalAccounts on App startup #356

Delete obsolete LocalAccounts on App startup #356

Conversation

Milena-Czierlinski commented Dec 3, 2024

Readiness checklist

jkoenig134 commented Dec 3, 2024