-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity Recovery Kits #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoenig134
added
wip
Work in Progress (blocks mergify from auto update the branch)
enhancement
New feature or request
labels
Dec 10, 2024
jkoenig134
removed
the
wip
Work in Progress (blocks mergify from auto update the branch)
label
Dec 11, 2024
jkoenig134
requested review from
sebbi08,
Magnus-Kuhn,
britsta and
Milena-Czierlinski
December 11, 2024 10:57
Magnus-Kuhn
reviewed
Dec 11, 2024
packages/runtime/src/useCases/transport/identityRecoveryKits/CreateIdentityRecoveryKit.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/useCases/transport/identityRecoveryKits/CreateIdentityRecoveryKit.ts
Outdated
Show resolved
Hide resolved
britsta
reviewed
Dec 11, 2024
packages/runtime/src/extensibility/facades/transport/IdentityRecoveryKitFacade.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/useCases/transport/identityRecoveryKits/CreateIdentityRecoveryKit.ts
Show resolved
Hide resolved
packages/runtime/src/useCases/transport/identityRecoveryKits/CreateIdentityRecoveryKit.ts
Show resolved
Hide resolved
britsta
previously approved these changes
Dec 11, 2024
Magnus-Kuhn
previously approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also didn't have anything left before @britsta took off
britsta
reviewed
Dec 12, 2024
packages/runtime/src/extensibility/facades/transport/IdentityRecoveryKitsFacade.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/extensibility/facades/transport/IdentityRecoveryKitsFacade.ts
Outdated
Show resolved
Hide resolved
Milena-Czierlinski
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Added UseCases
check for an existing Recovery Kit
create a Recovery Kit.
This deletes an existing “backup device” and the corresponding Token, makes sure that the Datawallet is enabled, creates a device flagged as “backup device” and creates a password protected long-lived Token for the created Device.
Testing
Testing the feature had to be split into two tests as the runtime is not able to do an onboarding.
For this reason
isBackupDevice: false
toisBackupDevice: true
to make it possible to create another recovery kit