Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Recovery Kits #363

Merged
merged 29 commits into from
Dec 12, 2024
Merged

Identity Recovery Kits #363

merged 29 commits into from
Dec 12, 2024

Conversation

jkoenig134
Copy link
Member

@jkoenig134 jkoenig134 commented Dec 10, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

Added UseCases

  • check for an existing Recovery Kit

  • create a Recovery Kit.

    This deletes an existing “backup device” and the corresponding Token, makes sure that the Datawallet is enabled, creates a device flagged as “backup device” and creates a password protected long-lived Token for the created Device.

Testing

Testing the feature had to be split into two tests as the runtime is not able to do an onboarding.

For this reason

  • the Runtime tests the actual UseCases
  • the AppRuntime tests
    • that the recovery kit is actually usable for recovery
    • that the Device that is taken for onboarding correctly if flagged from isBackupDevice: false to isBackupDevice: true to make it possible to create another recovery kit

@jkoenig134 jkoenig134 added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Dec 10, 2024
@jkoenig134 jkoenig134 changed the title Identity recovery kits Identity Recovery Kits Dec 10, 2024
@jkoenig134 jkoenig134 removed the wip Work in Progress (blocks mergify from auto update the branch) label Dec 11, 2024
@jkoenig134 jkoenig134 marked this pull request as ready for review December 11, 2024 11:19
@jkoenig134 jkoenig134 requested a review from britsta December 11, 2024 15:16
britsta
britsta previously approved these changes Dec 11, 2024
Magnus-Kuhn
Magnus-Kuhn previously approved these changes Dec 11, 2024
Copy link
Contributor

@Magnus-Kuhn Magnus-Kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also didn't have anything left before @britsta took off

@jkoenig134 jkoenig134 dismissed stale reviews from Magnus-Kuhn and britsta via cb5a3f2 December 12, 2024 07:30
@jkoenig134 jkoenig134 enabled auto-merge (squash) December 12, 2024 09:36
@jkoenig134 jkoenig134 merged commit 1a38321 into main Dec 12, 2024
19 checks passed
@jkoenig134 jkoenig134 deleted the identity-recovery-kits branch December 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants