Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Runtime error for attempt to establish Relationships to deleted Identities #366

Conversation

britsta
Copy link
Contributor

@britsta britsta commented Dec 11, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.
  • I self-reviewed the PR.

Description

Currently, only the Backbone throws a generic error.platform.recordNotFound error when an Identity tries to create a Relationship based on a loaded RelationshipTemplate if the creator of the corresponding RelationshipTemplate has been deleted in the meantime.

@britsta britsta added wip Work in Progress (blocks mergify from auto update the branch) enhancement New feature or request labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/modules/relationships/RelationshipsController.ts 50.00% 2 Missing ⚠️
packages/transport/src/core/TransportCoreErrors.ts 87.50% 1 Missing ⚠️
Files with missing lines Coverage Δ
packages/transport/src/core/TransportCoreErrors.ts 61.15% <87.50%> (+1.15%) ⬆️
...c/modules/relationships/RelationshipsController.ts 85.71% <50.00%> (-0.22%) ⬇️

@britsta britsta removed the wip Work in Progress (blocks mergify from auto update the branch) label Dec 12, 2024
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@jkoenig134 jkoenig134 marked this pull request as ready for review December 12, 2024 10:37
@britsta britsta merged commit f56c40d into main Dec 12, 2024
20 checks passed
@britsta britsta deleted the feature/add-runtime-errors-for-attempt-to-establish-relationships-to-deleted-identities branch December 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants