-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Runtime error for attempt to establish Relationships to deleted Identities #366
Merged
britsta
merged 8 commits into
main
from
feature/add-runtime-errors-for-attempt-to-establish-relationships-to-deleted-identities
Dec 12, 2024
Merged
Add Runtime error for attempt to establish Relationships to deleted Identities #366
britsta
merged 8 commits into
main
from
feature/add-runtime-errors-for-attempt-to-establish-relationships-to-deleted-identities
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britsta
added
wip
Work in Progress (blocks mergify from auto update the branch)
enhancement
New feature or request
labels
Dec 11, 2024
Codecov ReportAttention: Patch coverage is
|
…tablish-relationships-to-deleted-identities
britsta
removed
the
wip
Work in Progress (blocks mergify from auto update the branch)
label
Dec 12, 2024
jkoenig134
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
Milena-Czierlinski
approved these changes
Dec 12, 2024
britsta
deleted the
feature/add-runtime-errors-for-attempt-to-establish-relationships-to-deleted-identities
branch
December 12, 2024 10:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Currently, only the Backbone throws a generic
error.platform.recordNotFound
error when an Identity tries to create a Relationship based on a loaded RelationshipTemplate if the creator of the corresponding RelationshipTemplate has been deleted in the meantime.