fix: generate_batch returning None
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engintoklu
requested review from
Higgcz,
pliskowski,
flukeskywalker and
NaturalGradient
|
Simple enough; Approved. Flagging poetry error @Higgcz |
flukeskywalker
previously approved these changes
Feb 5, 2023
NaturalGradient
previously approved these changes
Feb 5, 2023
pliskowski
previously approved these changes
Feb 6, 2023
The method `Problem.generate_batch(...)` was unexpectedly returning `None` when the keyword arguments `center` and `stdev` are provided. The reason for this erroneous behavior was a missing `return` statement in the code. This commit fixes the issue by introducing the forgotten `return` statement.
Higgcz
dismissed stale reviews from pliskowski, NaturalGradient, and flukeskywalker
via
e4f2d0f
Higgcz
force-pushed
the
fix/generate-batch
branch
from
01da1fb
to
e4f2d0f
Compare
Higgcz
approved these changes
Feb 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 77.74% 77.73% -0.02%
==========================================
Files 49 49
Lines 7321 7322 +1
==========================================
Hits 5692 5692
- Misses 1629 1630 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
Problem.generate_batch(...)was unexpectedly returningNonewhen the keyword argumentscenterandstdevare provided. The reason for this erroneous behavior was a missingreturnstatement in the code. This pull request fixes the issue by introducing the forgottenreturnstatement.