Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C decomposition rate calculation on CUDA devices #64

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

NaturalGradient
Copy link
Collaborator

This PR resolves #61 by ensuring the decomposition rate of C is calculated using values on the CPU. It also ensures that the step size is reported as a float, regardless of the dtype and device of the problem. This is important as step size is a single value and is therefore reported like e.g. mean_eval.

@NaturalGradient NaturalGradient added the bug Something isn't working label Feb 5, 2023
@NaturalGradient NaturalGradient self-assigned this Feb 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Merging #64 (68167ac) into master (aa57024) will not change coverage.
The diff coverage is 66.66%.

❗ Current head 68167ac differs from pull request most recent head ccd95e8. Consider uploading reports for the commit ccd95e8 to get more accurate results

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   77.74%   77.74%           
=======================================
  Files          49       49           
  Lines        7321     7321           
=======================================
  Hits         5692     5692           
  Misses       1629     1629           
Impacted Files Coverage Δ
src/evotorch/algorithms/cmaes.py 82.94% <66.66%> (ø)
src/evotorch/core.py 74.48% <0.00%> (ø)
src/evotorch/logging.py 90.59% <0.00%> (ø)
src/evotorch/algorithms/mapelites.py 83.69% <0.00%> (ø)
src/evotorch/algorithms/restarter/restart.py 0.00% <0.00%> (ø)
src/evotorch/algorithms/distributed/gaussian.py 83.25% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

engintoklu
engintoklu previously approved these changes Feb 5, 2023
@Higgcz Higgcz merged commit 09fea8f into master Feb 13, 2023
@Higgcz Higgcz deleted the fix/cmaes-C-cuda branch February 13, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMAES "can't convert cuda:0 device type tensor to numpy" error
4 participants