Network/Util: Extract network util functions from MainService #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niley7464
requested review from
myungjoo,
again4you,
jaeyun-jung,
songgot,
wooksong,
gichan-jang,
anyj0527,
yeonykim2 and
a team
as code owners
wooksong
reviewed
Sep 25, 2024
| * | ||
| * @param isRunningOnEmulator Indicates whether the app is running on an emulator. | ||
| * @return The IP address as a string. | ||
| * @todo Add an ApplicationContext Parameter. |
There was a problem hiding this comment.
I copied the part from the original comment, is it okay if I delete it?
This patch extracts network realted util functions from MainService. Signed-off-by: Yelin Jeong <yelini.jeong@samsung.com>
niley7464
force-pushed
the
network/util
branch
from
68220bb
to
3eb1c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extracts network realted util functions from MainService.