Skip to content

Commit

Permalink
Merge pull request #507 from no-chris/handle-themes
Browse files Browse the repository at this point in the history
Handle ChordMark themes
  • Loading branch information
no-chris authored Dec 18, 2021
2 parents 647aaf5 + 0e593c6 commit 83b3c4d
Show file tree
Hide file tree
Showing 69 changed files with 1,183 additions and 1,455 deletions.
5 changes: 5 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
coverage
node_modules
build
SLOC
package.json
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"css-loader": "^6.5.1",
"css-minimizer-webpack-plugin": "^3.1.1",
"deep-freeze": "0.0.1",
"eslint": "^8.2.0",
"eslint": "^8.5.0",
"eslint-plugin-import": "^2.23.4",
"eslint-plugin-jam3": "^0.2.3",
"eslint-plugin-no-unsanitized": "^4.0.0",
Expand Down
1 change: 1 addition & 0 deletions packages/chord-charts-studio/.prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ coverage
node_modules
build
SLOC
package.json
30 changes: 15 additions & 15 deletions packages/chord-charts-studio/SLOC
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ Source code:

---------- Result ------------

Physical : 6290
Source : 5206
Comment : 127
Single-line comment : 59
Physical : 6319
Source : 5227
Comment : 128
Single-line comment : 60
Block comment : 68
Mixed : 5
Mixed : 6
Empty block comment : 0
Empty : 962
Empty : 970
To Do : 0

Number of files read : 145
Expand All @@ -20,14 +20,14 @@ Tests:

---------- Result ------------

Physical : 7438
Source : 6126
Physical : 7403
Source : 6102
Comment : 65
Single-line comment : 58
Block comment : 7
Mixed : 8
Empty block comment : 0
Empty : 1255
Empty : 1244
To Do : 0

Number of files read : 71
Expand All @@ -38,14 +38,14 @@ Total:

---------- Result ------------

Physical : 13728
Source : 11332
Comment : 192
Single-line comment : 117
Physical : 13722
Source : 11329
Comment : 193
Single-line comment : 118
Block comment : 75
Mixed : 13
Mixed : 14
Empty block comment : 0
Empty : 2217
Empty : 2214
To Do : 0

Number of files read : 216
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

This file was deleted.

This file was deleted.

2 changes: 1 addition & 1 deletion packages/chord-charts-studio/build/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
function gtag(){dataLayer.push(arguments);}
gtag('js', new Date());

gtag('config', 'G-EGKBT2J600');</script><link rel="icon" href="favicon.ico"><script defer="defer" src="vendors.e57b2f1a1a4debfe1406.js"></script><script defer="defer" src="main.e57b2f1a1a4debfe1406.js"></script><link href="css/main.e57b2f1a1a4debfe1406.css" rel="stylesheet"></head><body><div id="app" class="theme-dark"></div></body></html>
gtag('config', 'G-EGKBT2J600');</script><link rel="icon" href="favicon.ico"><script defer="defer" src="vendors.8f6ad30499a2a9bc845a.js"></script><script defer="defer" src="main.8f6ad30499a2a9bc845a.js"></script><link href="css/main.8f6ad30499a2a9bc845a.css" rel="stylesheet"></head><body><div id="app" class="theme-dark"></div></body></html>

Large diffs are not rendered by default.

Large diffs are not rendered by default.

This file was deleted.

This file was deleted.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

This file was deleted.

This file was deleted.

7 changes: 4 additions & 3 deletions packages/chord-charts-studio/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,12 @@
"@testing-library/user-event": "^13.5.0"
},
"dependencies": {
"chord-mark": "^0.8.0",
"chord-mark-2-chordpro": "^0.8.0",
"chord-mark": "^0.9.0",
"chord-mark-2-chordpro": "^0.9.0",
"chord-mark-themes": "^0.9.1",
"chordsheetjs": "^5.1.2",
"combine-section-reducers": "^1.0.6",
"core-js": "^3.15.2",
"core-js": "^3.20.0",
"dompurify": "^2.2.9",
"file-saver": "^2.0.5",
"filesize": "^8.0.6",
Expand Down
29 changes: 29 additions & 0 deletions packages/chord-charts-studio/scss/_base.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
@import 'abstract';

$themes: (
light: (),
dark: (
link1: cv(dark-accent),
link1-hover: cv(dark-accent, light10),
link1-active: cv(dark-accent, light20),
),
);

html {
/* switching to border-box model for all elements */
box-sizing: border-box;
Expand All @@ -14,3 +25,21 @@ body {
font-family: $font-family-base;
line-height: $line-height-base;
}

.link1 {
@include themify($themes) {
color: themed('link1');
}

&:hover {
@include themify($themes) {
color: themed('link1-hover');
}
}

&:active {
@include themify($themes) {
color: themed('link1-active');
}
}
}
7 changes: 7 additions & 0 deletions packages/chord-charts-studio/scss/abstract/_typography.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
@use 'sass:math';

// ChordMark

$cmFontStack: SFMono-Regular, Menlo, Monaco, Consolas, 'Liberation Mono',
'Courier New', monospace;
$cmFontSize: 13px;
$cmLineHeight: 1.65em;

// Source: Knacss

// Font families
Expand Down
Loading

0 comments on commit 83b3c4d

Please sign in to comment.