Skip to content
This repository has been archived by the owner on May 2, 2021. It is now read-only.

Deprecate size prop #45

Closed
2 tasks done
no23reason opened this issue Jun 20, 2017 · 0 comments
Closed
2 tasks done

Deprecate size prop #45

no23reason opened this issue Jun 20, 2017 · 0 comments
Assignees
@no23reason

Comments

@no23reason
Copy link
Owner

no23reason commented Jun 20, 2017 •
edited
Loading

In #36 a new more flexible way to size the QR code was introduced. This means the size prop is now obsolete and we should get rid of it. The change will happen in two steps:

  • a new minor version with a deprecation warning
  • a new major version with the prop removed
@no23reason no23reason self-assigned this Jun 20, 2017
@no23reason no23reason mentioned this issue Jun 20, 2017
Merged
no23reason added a commit that referenced this issue Jun 20, 2017
@no23reason
refactor: remove 'size' prop
2a0428c 
The 'size' prop was removed in favour of 'className', 'style' and 'width' props

BREAKING CHANGE: The 'size' prop was removed and will no longer work

#45
@no23reason no23reason mentioned this issue Jun 20, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@no23reason no23reason

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@no23reason