[Mellanox] Fix timing issue in lpmode change #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaOrMlnx
force-pushed
the
lpmode_timing_fix
branch
from
fa6c0a8
to
54d8265
Compare
keboliu
reviewed
Feb 26, 2024
noaOrMlnx
force-pushed
the
lpmode_timing_fix
branch
from
54d8265
to
022a787
Compare
keboliu
approved these changes
Feb 29, 2024
noaOrMlnx
force-pushed
the
lpmode_timing_fix
branch
from
022a787
to
5e38ca0
Compare
noaOrMlnx
pushed a commit
that referenced
this pull request
Sep 30, 2024
…tically (sonic-net#20199) #### Why I did it src/sonic-dash-api ``` * 0b33087 - (HEAD -> master, origin/master, origin/HEAD) Add local region ID field to Dash appliance table (#26) (31 hours ago) [Mukesh Moopath Velayudhan] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Changing LPMODE timing is changed between cables.
We want to add functinoality to make sure LPMODE has changed.
Work item tracking
How I did it
Add wait_until function to make sure lpmode was changed
How to verify it
sfputil lpmode on
sfputil lpmode off
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)