Add SN5640 SIMX platform with default SKU #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaOrMlnx
force-pushed
the
sn5640_bringup
branch
from
43e86d7
to
d321226
Compare
stephenxs
reviewed
Jul 18, 2024
| {% set default_cable = '300m' %} | ||
| {% set ingress_lossless_pool_size = '31502336' %} | ||
| {% set ingress_lossy_pool_size = '31502336' %} | ||
| {% set egress_lossless_pool_size = '138240000' %} |
There was a problem hiding this comment.
I am afraid this value is too big. if the guaranteed size is 130.9, the number should be round_down(130.9*1024*1024, 192)
noaOrMlnx
force-pushed
the
sn5640_bringup
branch
from
d321226
to
43cd2cf
Compare
noaOrMlnx
force-pushed
the
sn5640_bringup
branch
from
43cd2cf
to
be36ad2
Compare
stephenxs
reviewed
Sep 4, 2024
| @@ -0,0 +1 @@ | |||
| ../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers.json.j2 | |||
There was a problem hiding this comment.
../../x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/buffers.json.j2
Suggested change
| ../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers.json.j2 | |
| ../../x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/buffers.json.j2 |
There was a problem hiding this comment.
we need to use templates from Mellanox-SN2700-D48C8
| {% set ingress_lossless_pool_size = '2359296' %} | ||
| {% set ingress_lossy_pool_size = '2359296' %} | ||
| {% set egress_lossless_pool_size = '136209408' %} | ||
| {% set egress_lossy_pool_size = '2359296' %} |
There was a problem hiding this comment.
Suggested change
| {% set egress_lossy_pool_size = '2359296' %} | |
| {% set egress_lossy_pool_size = '2359296' %} | |
| {% set ingress_lossless_pool_xoff = '1024000' %} |
| {% set ingress_lossless_pool_size = '18874368' %} | ||
| {% set ingress_lossy_pool_size = '71459840' %} | ||
| {% set egress_lossless_pool_size = '136209408' %} | ||
| {% set egress_lossy_pool_size = '71459840' %} |
There was a problem hiding this comment.
Suggested change
| {% set egress_lossy_pool_size = '71459840' %} | |
| {% set egress_lossy_pool_size = '71459840' %} | |
| {% set ingress_lossless_pool_xoff = '1024000' %} |
stephenxs
reviewed
Sep 10, 2024
| @@ -0,0 +1 @@ | |||
| ../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/buffers.json.j2 | |||
There was a problem hiding this comment.
we need to use templates from Mellanox-SN2700-D48C8
| #} | ||
| {% set default_cable = '40m' %} | ||
| {% set ingress_lossless_pool_size = '73684992' %} | ||
| {% set ingress_lossless_pool_xoff = '57828352' %} |
noaOrMlnx
force-pushed
the
sn5640_bringup
branch
from
0107a17
to
3c5e828
Compare
|
@stephenxs thanks for the comment. all were addressed. |
stephenxs
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added new platform and SKU for SN5640.
Currently, number of up/down links is 256/256.
Why I did it
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)