Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'NameError("name 'chassis' is not defined")' error in thermalctld log #1

Closed
wants to merge 1 commit into from

Conversation

noaOrMlnx
Copy link
Owner

Description

Changed the chassis definition to be a part of the class do the chassis will be found in run() function

Motivation and Context

Without the change, an error appears in syslog.
ERR pmon#thermalctld: Caught exception while running thermal policy - NameError("name 'chassis' is not defined")

How Has This Been Tested?

N/A

Additional Information (Optional)

@liat-grozovik
Copy link

@noaOrMlnx can you explain what changed that we need this fix now?

@liat-grozovik
Copy link

Can you please also ask Kebo or Junchao to take a look at it?

@liat-grozovik
Copy link

You have a typo in the description
"Changed the chassis definition to be a part of the class do the chassis will be found in run() function" should be
"Changed the chassis definition to be a part of the class so the chassis will be found in run() function

@noaOrMlnx
Copy link
Owner Author

@liat-grozovik
didn't receive notification on this comment so I see that just now.

  1. In this PR [thermalctld] Refactor to allow for greater unit test coverage; Add more unit tests sonic-net/sonic-platform-daemons#157 there was an intention to improve thermalctld but a mistake was done. hence, the above mentioned error appeared in syslog.

  2. Junchao reviewed the public PR - [thermalctld] Fix 'NameError("name 'chassis' is not defined")' error in log sonic-net/sonic-platform-daemons#170

  3. Fixed in public PR. thanks.

public PR was already merged.

@noaOrMlnx noaOrMlnx closed this Apr 8, 2021
@noaOrMlnx noaOrMlnx deleted the fix_chassis_error branch April 8, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants