Refactor Host Tx Ready setting #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaOrMlnx
force-pushed
the
host_tx_ready_refactor
branch
from
93080c5
to
7e02d65
Compare
noaOrMlnx
force-pushed
the
host_tx_ready_refactor
branch
from
7e02d65
to
95ac5a9
Compare
stepanblyschak
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Update the call to setHostTxReady() to receive Port instead of port_id.
Why I did it
So we won't need to call getPort() inside the function, and we will be able to call setHostTxReady from within port initialization.
How I verified it
Tested it on running switch.
Details if related