refactor!: make all models and config fields private #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaione
added
c-core
noaione
changed the title
noaione
changed the title
noaione
force-pushed
the
refactor/struct-getter
branch
from
1a3d90a
to
50dc69b
Compare
noaione
force-pushed
the
refactor/struct-getter
branch
from
50dc69b
to
fda0e67
Compare
|
This pull request has been locked because it has been inactive for 30 days. Please open a new pull request if you are still working on this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title said, this PR makes all field in the models field private and in turns use a new macro called
AutoGetterto automatically make a getter function for each field.Checklist: