PC-11136 Allow underscores and parenthesis in azure resource id (#162)

* Allow underscores and parenthesis in Azure resource id Co-authored-by: Jakub Mikłasz <jakub.miklasz@nobl9.com> --------- Co-authored-by: Jakub Mikłasz <jakub.miklasz@nobl9.com>
nobl9 · Nov 16, 2023 · c8a7ec3 · c8a7ec3
1 parent 426d480
commit c8a7ec3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/manifest/v1alpha/validator.go b/manifest/v1alpha/validator.go
@@ -47,7 +47,7 @@ const (
 	GCSNonDomainNameBucketMaxLength int    = 63
 	CloudWatchNamespaceRegex        string = `^[0-9A-Za-z.\-_/#:]{1,255}$`
 	HeaderNameRegex                 string = `^([a-zA-Z0-9]+[_-]?)+$`
-	AzureResourceIDRegex            string = `^\/subscriptions\/[a-zA-Z0-9-]+\/resourceGroups\/[a-zA-Z0-9-]+\/providers\/[a-zA-Z0-9-\._]+\/[a-zA-Z0-9-_]+\/[a-zA-Z0-9-_]+$` //nolint:lll
+	AzureResourceIDRegex            string = `^\/subscriptions\/[a-zA-Z0-9-]+\/resourceGroups\/[a-zA-Z0-9-._()]+\/providers\/[a-zA-Z0-9-.()_]+\/[a-zA-Z0-9-_()]+\/[a-zA-Z0-9-_()]+$` //nolint:lll
 )
 
 // Values used to validate time window size

diff --git a/manifest/v1alpha/validator_test.go b/manifest/v1alpha/validator_test.go
@@ -894,6 +894,11 @@ func TestValidateAzureResourceID(t *testing.T) {
 			resourceID: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/vm-123_x", //nolint:lll
 			isValid:    true,
 		},
+		{
+			desc:       "valid resource id with _ in rg",
+			resourceID: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/mc_().rg-xxx-01_ups-aks_eu_west/providers/Microsoft.()Network/loadBalancers1_-()/kubernetes", //nolint:lll
+			isValid:    true,
+		},
 	}
 
 	val := v.New()