-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PC-10133: Move api models to separate package #143
Merged
nieomylnieja
merged 33 commits into
main
from
PC-10133-move-api-models-to-separate-package
Oct 11, 2023
Merged
PC-10133: Move api models to separate package #143
nieomylnieja
merged 33 commits into
main
from
PC-10133-move-api-models-to-separate-package
Oct 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-into-separate-package
nieomylnieja
changed the base branch from
main
to
PC-10133-move-service-into-separate-package
October 5, 2023 09:50
Base automatically changed from
PC-10133-move-service-into-separate-package
to
main
October 6, 2023 13:24
nieomylnieja
requested review from
skrolikiewicz and
daniel-zelazny
as code owners
October 10, 2023 21:31
BSski
requested changes
Oct 11, 2023
BSski
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API models which are not part of our IaC managed objects (SLO, Service etc.) but are simply payloads used to create and read requests to our HTTP API should be moved to a more appropriate location. Since they are directly tied to
sdk.Client
and its methods and don't serve any purpose outside ofsdk.Client
scope, they should be moved tosdk
package, into a sub-package calledmodels
.These models include:
Currently Replay models have been moved to models pkg as a role model. SLI Analysis has been moved to
n9
as it does not contain all the models for all analysis endpoints.To accommodate the changes and further polish up the validation package several major changes were introduced:
Include
keyword in property rules, it also results in a parent property path/name being prepended to its childrenStopOnError
Rules
,When
,Include
andStopOnError
is executed sequentially, order of steps matters!