Skip to content

Commit

Permalink
chore: change import path to v4
Browse files Browse the repository at this point in the history
  • Loading branch information
johnletey committed Nov 1, 2023
1 parent a3437c5 commit 8122c83
Show file tree
Hide file tree
Showing 218 changed files with 1,042 additions and 1,516 deletions.
45 changes: 21 additions & 24 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -120,35 +120,32 @@ endif
go-mod-cache build interchaintest get-heighliner local-image \

###############################################################################
### Protobuf ###
### Protobuf ###
###############################################################################
containerProtoVer=v0.2
containerProtoImage=tendermintdev/sdk-proto-gen:$(containerProtoVer)
containerProtoGen=cosmos-sdk-proto-gen-$(containerProtoVer)
containerProtoGenSwagger=cosmos-sdk-proto-gen-swagger-$(containerProtoVer)
containerProtoFmt=cosmos-sdk-proto-fmt-$(containerProtoVer)

proto-all: proto-format proto-lint proto-gen
BUF_VERSION=1.27.2

proto-gen:
@echo "Generating Protobuf files"
@if docker ps -a --format '{{.Names}}' | grep -Eq "^${containerProtoGen}$$"; then docker start -a $(containerProtoGen); else docker run --name $(containerProtoGen) -v $(CURDIR):/workspace --workdir /workspace $(containerProtoImage) \
sh ./scripts/protocgen.sh; fi
proto-all: proto-format proto-lint proto-gen

proto-format:
@echo "Formatting Protobuf files"
@if docker ps -a --format '{{.Names}}' | grep -Eq "^${containerProtoFmt}$$"; then docker start -a $(containerProtoFmt); else docker run --name $(containerProtoFmt) -v $(CURDIR):/workspace --workdir /workspace tendermintdev/docker-build-proto \
find ./ -not -path "./third_party/*" -name "*.proto" -exec clang-format -i {} \; ; fi
@echo "🤖 Running protobuf formatter..."
@docker run --rm --volume "$(PWD)":/workspace --workdir /workspace \
bufbuild/buf:$(BUF_VERSION) format --diff --write
@echo "✅ Completed protobuf formatting!"

proto-swagger-gen:
@echo "Generating Protobuf Swagger"
@if docker ps -a --format '{{.Names}}' | grep -Eq "^${containerProtoGenSwagger}$$"; then docker start -a $(containerProtoGenSwagger); else docker run --name $(containerProtoGenSwagger) -v $(CURDIR):/workspace --workdir /workspace $(containerProtoImage) \
sh ./scripts/protoc-swagger-gen.sh; fi
proto-gen:
@echo "🤖 Generating code from protobuf..."
@docker run --rm --volume "$(PWD)":/workspace --workdir /workspace \
noble-proto sh ./proto/generate.sh
@echo "✅ Completed code generation!"

proto-lint:
@$(DOCKER_BUF) lint --error-format=json

proto-check-breaking:
@$(DOCKER_BUF) breaking --against $(HTTPS_GIT)#branch=main

.PHONY: proto-all proto-gen proto-format proto-swagger-gen proto-lint proto-check-breaking
@echo "🤖 Running protobuf linter..."
@docker run --rm --volume "$(PWD)":/workspace --workdir /workspace \
bufbuild/buf:$(BUF_VERSION) lint
@echo "✅ Completed protobuf linting!"

proto-setup:
@echo "🤖 Setting up protobuf environment..."
@docker build --rm --tag noble-proto:latest --file proto/Dockerfile .
@echo "✅ Setup protobuf environment!"
6 changes: 3 additions & 3 deletions app/ante.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
fiattokenfactory "github.com/circlefin/noble-fiattokenfactory/x/fiattokenfactory/keeper"
fiattokenfactorytypes "github.com/circlefin/noble-fiattokenfactory/x/fiattokenfactory/types"
"github.com/cosmos/cosmos-sdk/types/bech32"
tokenfactory "github.com/strangelove-ventures/noble/x/tokenfactory/keeper"
tokenfactorytypes "github.com/strangelove-ventures/noble/x/tokenfactory/types"
tokenfactory "github.com/strangelove-ventures/noble/v4/x/tokenfactory/keeper"
tokenfactorytypes "github.com/strangelove-ventures/noble/v4/x/tokenfactory/types"

sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
Expand All @@ -16,7 +16,7 @@ import (
ibcante "github.com/cosmos/ibc-go/v4/modules/core/ante"
ibckeeper "github.com/cosmos/ibc-go/v4/modules/core/keeper"

feeante "github.com/strangelove-ventures/noble/x/globalfee/ante"
feeante "github.com/strangelove-ventures/noble/v4/x/globalfee/ante"
)

type HandlerOptions struct {
Expand Down
30 changes: 15 additions & 15 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,21 +93,21 @@ import (
"github.com/cosmos/cosmos-sdk/x/staking"
stakingkeeper "github.com/cosmos/cosmos-sdk/x/staking/keeper"
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
"github.com/strangelove-ventures/noble/app/upgrades/argon"
"github.com/strangelove-ventures/noble/app/upgrades/argon4"
"github.com/strangelove-ventures/noble/app/upgrades/neon"
"github.com/strangelove-ventures/noble/app/upgrades/radon"
v3m1p0 "github.com/strangelove-ventures/noble/app/upgrades/v3.1.0"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/docs"
"github.com/strangelove-ventures/noble/x/blockibc"
"github.com/strangelove-ventures/noble/x/globalfee"
tariff "github.com/strangelove-ventures/noble/x/tariff"
tariffkeeper "github.com/strangelove-ventures/noble/x/tariff/keeper"
tarifftypes "github.com/strangelove-ventures/noble/x/tariff/types"
tokenfactorymodule "github.com/strangelove-ventures/noble/x/tokenfactory"
tokenfactorymodulekeeper "github.com/strangelove-ventures/noble/x/tokenfactory/keeper"
tokenfactorymoduletypes "github.com/strangelove-ventures/noble/x/tokenfactory/types"
"github.com/strangelove-ventures/noble/v4/app/upgrades/argon"
"github.com/strangelove-ventures/noble/v4/app/upgrades/argon4"
"github.com/strangelove-ventures/noble/v4/app/upgrades/neon"
"github.com/strangelove-ventures/noble/v4/app/upgrades/radon"
v3m1p0 "github.com/strangelove-ventures/noble/v4/app/upgrades/v3.1.0"
"github.com/strangelove-ventures/noble/v4/cmd"
"github.com/strangelove-ventures/noble/v4/docs"
"github.com/strangelove-ventures/noble/v4/x/blockibc"
"github.com/strangelove-ventures/noble/v4/x/globalfee"
tariff "github.com/strangelove-ventures/noble/v4/x/tariff"
tariffkeeper "github.com/strangelove-ventures/noble/v4/x/tariff/keeper"
tarifftypes "github.com/strangelove-ventures/noble/v4/x/tariff/types"
tokenfactorymodule "github.com/strangelove-ventures/noble/v4/x/tokenfactory"
tokenfactorymodulekeeper "github.com/strangelove-ventures/noble/v4/x/tokenfactory/keeper"
tokenfactorymoduletypes "github.com/strangelove-ventures/noble/v4/x/tokenfactory/types"

cctp "github.com/circlefin/noble-cctp/x/cctp"
cctpkeeper "github.com/circlefin/noble-cctp/x/cctp/keeper"
Expand Down
4 changes: 2 additions & 2 deletions app/simulation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import (
"os"
"testing"

"github.com/strangelove-ventures/noble/app"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/app"
"github.com/strangelove-ventures/noble/v4/cmd"

"github.com/cosmos/cosmos-sdk/baseapp"
"github.com/cosmos/cosmos-sdk/codec"
Expand Down
4 changes: 2 additions & 2 deletions app/upgrades/radon/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import (
storeTypes "github.com/cosmos/cosmos-sdk/store/types"

// GlobalFee
globalFeeTypes "github.com/strangelove-ventures/noble/x/globalfee/types"
globalFeeTypes "github.com/strangelove-ventures/noble/v4/x/globalfee/types"
// Tariff
tariffTypes "github.com/strangelove-ventures/noble/x/tariff/types"
tariffTypes "github.com/strangelove-ventures/noble/v4/x/tariff/types"
// Upgrade
upgradeTypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
)
Expand Down
4 changes: 2 additions & 2 deletions app/upgrades/radon/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (

fiattokenfactorykeeper "github.com/circlefin/noble-fiattokenfactory/x/fiattokenfactory/keeper"
upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
globalfeetypes "github.com/strangelove-ventures/noble/x/globalfee/types"
globalfeetypes "github.com/strangelove-ventures/noble/v4/x/globalfee/types"

tarifftypes "github.com/strangelove-ventures/noble/x/tariff/types"
tarifftypes "github.com/strangelove-ventures/noble/v4/x/tariff/types"
)

func CreateRadonUpgradeHandler(
Expand Down
1 change: 0 additions & 1 deletion buf.yaml → buf.work.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
version: v1
directories:
- proto
- third_party/proto
4 changes: 2 additions & 2 deletions cmd/nobled/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import (

svrcmd "github.com/cosmos/cosmos-sdk/server/cmd"

"github.com/strangelove-ventures/noble/app"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/app"
"github.com/strangelove-ventures/noble/v4/cmd"
)

func main() {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/strangelove-ventures/noble
module github.com/strangelove-ventures/noble/v4

go 1.21

Expand Down
2 changes: 1 addition & 1 deletion interchaintest/cctp_deposit_for_burn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4"
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
)
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/cctp_deposit_for_burn_with_caller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4"
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
)
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/cctp_receive_message_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4"
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
)
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/cctp_receive_message_with_caller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4"
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
)
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/cctp_replace_deposit_for_burn_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4"
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
)
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/cctp_roles_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4"
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
)
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/genesis_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4/ibc"
"github.com/strangelove-ventures/interchaintest/v4/relayer"
"github.com/strangelove-ventures/interchaintest/v4/relayer/rly"
tokenfactorytypes "github.com/strangelove-ventures/noble/x/tokenfactory/types"
tokenfactorytypes "github.com/strangelove-ventures/noble/v4/x/tokenfactory/types"
proposaltypes "github.com/strangelove-ventures/paramauthority/x/params/types/proposal"
upgradetypes "github.com/strangelove-ventures/paramauthority/x/upgrade/types"
)
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/globalfee_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4"
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
proposaltypes "github.com/strangelove-ventures/paramauthority/x/params/types/proposal"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
Expand Down
4 changes: 2 additions & 2 deletions interchaintest/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ require (
github.com/gogo/protobuf v1.3.3
github.com/icza/dyno v0.0.0-20220812133438-f0b6f8a18845
github.com/strangelove-ventures/interchaintest/v4 v4.0.0-20231020192006-848acaeab959
github.com/strangelove-ventures/noble v1.0.1-0.20230717234609-400609f26a31
github.com/strangelove-ventures/noble/v4 v4.0.0
github.com/strangelove-ventures/paramauthority v1.1.0
github.com/stretchr/testify v1.8.4
go.uber.org/zap v1.24.0
Expand Down Expand Up @@ -190,7 +190,7 @@ replace (
github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

// use local version of noble
github.com/strangelove-ventures/noble => ./..
github.com/strangelove-ventures/noble/v4 => ./..

// use cosmos compatible syndtr/goleveldb
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/noble_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/ibc"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/x/tokenfactory/types"
"github.com/strangelove-ventures/noble/v4/x/tokenfactory/types"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
)
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/paramauthority_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/ibc"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
proposaltypes "github.com/strangelove-ventures/paramauthority/x/params/types/proposal"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zaptest"
Expand Down
2 changes: 1 addition & 1 deletion interchaintest/upgrade_radon_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/strangelove-ventures/interchaintest/v4/chain/cosmos"
"github.com/strangelove-ventures/interchaintest/v4/ibc"
globalfeetypes "github.com/strangelove-ventures/noble/x/globalfee/types"
globalfeetypes "github.com/strangelove-ventures/noble/v4/x/globalfee/types"
"github.com/stretchr/testify/require"
)

Expand Down
2 changes: 1 addition & 1 deletion interchaintest/upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"github.com/strangelove-ventures/interchaintest/v4/ibc"
"github.com/strangelove-ventures/interchaintest/v4/testreporter"
"github.com/strangelove-ventures/interchaintest/v4/testutil"
"github.com/strangelove-ventures/noble/cmd"
"github.com/strangelove-ventures/noble/v4/cmd"
upgradetypes "github.com/strangelove-ventures/paramauthority/x/upgrade/types"
"github.com/stretchr/testify/require"
"go.uber.org/zap"
Expand Down
23 changes: 23 additions & 0 deletions proto/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
FROM bufbuild/buf:1.27.2 as BUILDER
FROM golang:1.21-alpine

RUN apk add --no-cache \
nodejs \
npm \
git \
make

RUN go install github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway@latest

RUN git clone https://github.com/regen-network/protobuf.git; \
cd protobuf; \
go mod download; \
make install; \
cd ..

RUN git clone https://github.com/regen-network/cosmos-proto.git; \
cd cosmos-proto/protoc-gen-gocosmos; \
go install .; \
cd ..

COPY --from=BUILDER /usr/local/bin /usr/local/bin
8 changes: 8 additions & 0 deletions proto/buf.gen.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
version: v1
plugins:
- name: gocosmos
out: ..
opt:
- plugins=grpc
- name: grpc-gateway
out: ..
8 changes: 8 additions & 0 deletions proto/buf.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Generated by buf. DO NOT EDIT.
version: v1
deps:
- remote: buf.build
owner: noble
repository: cosmos-sdk
commit: b18b492ea3364d5fa88fe3ead0b57a95
digest: shake256:ce3896962b4241dbaa0776fa00e661184b8bdba629722b9f38bc7e221e04d379b3ad18531f33e2552ba675cca39381dcf0df693ec146c14db719741510c24852
17 changes: 17 additions & 0 deletions proto/buf.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
version: v1
deps:
- buf.build/noble/cosmos-sdk:v0.45.16
breaking:
use:
- FILE
lint:
use:
- DEFAULT
except:
- SERVICE_SUFFIX
- RPC_REQUEST_STANDARD_NAME
- RPC_RESPONSE_STANDARD_NAME
# TODO: Remove the following exceptions later!
- FIELD_LOWER_SNAKE_CASE
- PACKAGE_DIRECTORY_MATCH
- PACKAGE_VERSION_SUFFIX
6 changes: 6 additions & 0 deletions proto/generate.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
cd proto
buf generate
cd ..

cp -r github.com/strangelove-ventures/noble/v4/* ./
rm -rf github.com
4 changes: 2 additions & 2 deletions proto/globalfee/genesis.proto
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
syntax = "proto3";
package noble.globalfee;

import "gogoproto/gogo.proto";
import "cosmos/base/v1beta1/coin.proto";
import "gogoproto/gogo.proto";

option go_package = "github.com/strangelove-ventures/noble/x/globalfee/types";
option go_package = "github.com/strangelove-ventures/noble/v4/x/globalfee/types";

// GenesisState - initial state of module
message GenesisState {
Expand Down
Loading

0 comments on commit 8122c83

Please sign in to comment.