Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare argon #196

Merged
merged 7 commits into from
Jul 14, 2023
Merged

chore: prepare argon #196

merged 7 commits into from
Jul 14, 2023

Conversation

johnletey
Copy link
Member

No description provided.

@johnletey johnletey self-assigned this Jun 29, 2023
@boojamya
Copy link
Member

boojamya commented Jun 30, 2023 •
edited
Loading

These tests are passing for me locally. Need to look into why they aren't passing on the runner.

This may have to do with the go test timeout.
Maybe try adding a -timeout 15m to the ictest-chain-upgrade-grand-1 and ictest-chain-upgrade-noble-1 make commands?

@boojamya boojamya self-assigned this Jul 5, 2023
@boojamya boojamya force-pushed the john/prepare-argon branch from 8729d81 to 8f5cbf7 Compare July 6, 2023 22:52
@boojamya
Copy link
Member

boojamya commented Jul 7, 2023

Test are passing!
Issue was with the github action. It wasn't building the binary from the "pushed" version of the repo.

@boojamya boojamya added the backport/v4.0.x backport patches to v4.0.x branch label Jul 14, 2023
boojamya
boojamya approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@boojamya boojamya merged commit 4cc95ae into main Jul 14, 2023
@boojamya boojamya deleted the john/prepare-argon branch July 14, 2023 23:17
mergify bot pushed a commit that referenced this pull request Jul 14, 2023
@johnletey @mergify
chore: prepare argon (#196)
8f72bb2 
Co-authored-by: Dan Kanefsky <56059752+boojamya@users.noreply.github.com>
(cherry picked from commit 4cc95ae)
@mergify mergify bot mentioned this pull request Jul 14, 2023
Merged
boojamya added a commit that referenced this pull request Jul 17, 2023
@mergify @johnletey @boojamya
chore: prepare argon (backport #196) (#210)
2f53808 
Co-authored-by: John Letey <john@nobleassets.xyz>
Co-authored-by: Dan Kanefsky <daniel.kanefsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojamya boojamya boojamya approved these changes

Assignees

@boojamya boojamya

@johnletey johnletey

Labels
backport/v4.0.x backport patches to v4.0.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnletey @boojamya