Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove router #248

Merged
merged 3 commits into from
Oct 17, 2023
Merged

chore: remove router #248

merged 3 commits into from
Oct 17, 2023

Conversation

johnletey
Copy link
Member

No description provided.

@johnletey johnletey requested review from agouin and boojamya October 16, 2023 11:11
@johnletey johnletey self-assigned this Oct 16, 2023
@johnletey johnletey mentioned this pull request Oct 16, 2023
Closed
agouin
agouin approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@agouin agouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for mainnet. Note to remember the Removed router in the StoreUpgrades for the testnet upgrade handler once we get to it.

@johnletey johnletey merged commit cfbe214 into main Oct 17, 2023
18 checks passed
@johnletey johnletey deleted the john/remove-router branch October 17, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agouin agouin agouin approved these changes

@boojamya boojamya Awaiting requested review from boojamya

Assignees

@johnletey johnletey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnletey @agouin