Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v4.0.0-rc0 #255

Merged
merged 6 commits into from
Nov 1, 2023
Merged

chore: prepare v4.0.0-rc0 #255

merged 6 commits into from
Nov 1, 2023

Conversation

johnletey
Copy link
Member

No description provided.

@johnletey johnletey self-assigned this Oct 25, 2023
@johnletey johnletey marked this pull request as ready for review November 1, 2023 10:51
@johnletey johnletey requested review from agouin and boojamya November 1, 2023 10:52
},
{
upgradeName: "argon",
image: nobleImageInfo[0],
// postUpgrade: testPostArgonUpgradeMainnet,
postUpgrade: testPostArgonUpgrade,
Copy link
Member

@boojamya boojamya Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we are going to have to remove the post-upgrade part from the mainnet upgrade test if we want this to pass.

This is because of the way we created the fiat-tokenfactory where you must have an owner in state. IE, we hard coded the owner role in the neon upgrade handler.

The reason this works in the testnet upgrade test is because we altered the fiat-tokenfactory owner in this image of noble:
https://github.com/strangelove-ventures/noble/blob/72e36f89a65376d40a339cb9cf8b99fc461628cf/interchaintest/upgrade_grand-1_test.go#L25

The owner in the image above, matches the owner here:
https://github.com/strangelove-ventures/noble/blob/72e36f89a65376d40a339cb9cf8b99fc461628cf/interchaintest/upgrade_argon_test.go#L38

app/upgrades/argon/store.go Outdated Show resolved Hide resolved
@johnletey johnletey enabled auto-merge (squash) November 1, 2023 17:13
@johnletey johnletey merged commit 7cbb8c4 into main Nov 1, 2023
23 checks passed
@johnletey johnletey deleted the john/prepare-argon-rc0 branch November 1, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants