feat: prepare v7.0.0

[johnletey]

No description provided.

[coderabbitai]

Walkthrough

The changes introduced in this pull request encompass a significant update to the Noble platform, including the addition of a new x/florin module for issuing Monerium's EUR emoney (EURe), support for signerless account registration in the x/forwarding module, and enhancements to the x/halo module for improved recipient role verification in fiat transactions. Additionally, various files were modified to update import paths, streamline the handling of banking operations, and refine fee-related functionalities.

Changes

File	Change Summary
.changelog/unreleased/features/403-signerless-forwarding.md	Added support for signerless account registration in x/forwarding.
.changelog/v7.0.0/bug-fixes/405-bump-halo.md	Updated x/halo to correctly check recipient roles when trading to fiat.
.changelog/v7.0.0/summary.md	Introduced x/florin module for native issuance of Monerium's EUR emoney (EURe).
CHANGELOG.md	Updated to reflect version 7.0.0 release, including new x/florin module and bug fixes.
Makefile	Modified Protobuf dependency version from 1.39 to 1.40.
app/ante.go	Removed BankKeeper interface and related usage, simplifying the signature verification process.
app/app.go	Updated import paths for florin module and modified HandlerOptions for banking operations.
app/upgrades/numus/store.go	Changed import path for florintypes package.
app/upgrades/numus/upgrade.go	Set specific addresses for florinKeeper.SetOwner and SetBlacklistOwner for mainnet.
interchaintest/forwarding_test.go	Removed TestForwarding_RegisterSignerlessly function.
interchaintest/upgrade_grand-1_test.go	Updated image field for upgradeName: "numus" in TestGrand1ChainUpgrade.
x/globalfee/ante/fee.go	Modified logic for bypassing minimum fee requirements in AnteHandle.
x/globalfee/ante/fee_utils.go	Removed isSignerlessForwardingRegistration function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ForwardingModule
    participant AccountKeeper
    participant HaloModule

    User->>ForwardingModule: Register account (signerless)
    ForwardingModule->>AccountKeeper: Verify identity
    AccountKeeper-->>ForwardingModule: Identity verified
    ForwardingModule-->>User: Account registered successfully

    User->>HaloModule: Trade to fiat
    HaloModule->>HaloModule: Check recipient roles
    HaloModule-->>User: Trade executed with role verification

Loading

🐇 In the land of code, changes abound,
New florin module, a treasure found.
Signerless paths now open wide,
With each update, we take in stride.
Bugs fixed, roles checked, all in a row,
Hopping forward, watch us grow! 🐇✨

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 004502a and 80ce494.

Files ignored due to path filters (4)

• go.mod is excluded by !**/*.mod
• go.sum is excluded by !**/*.sum, !**/*.sum
• interchaintest/go.mod is excluded by !**/*.mod
• interchaintest/go.sum is excluded by !**/*.sum, !**/*.sum

Files selected for processing (13)

• .changelog/unreleased/features/403-signerless-forwarding.md (0 hunks)
• .changelog/v7.0.0/bug-fixes/405-bump-halo.md (1 hunks)
• .changelog/v7.0.0/summary.md (1 hunks)
• CHANGELOG.md (1 hunks)
• Makefile (1 hunks)
• app/ante.go (1 hunks)
• app/app.go (2 hunks)
• app/upgrades/numus/store.go (1 hunks)
• app/upgrades/numus/upgrade.go (2 hunks)
• interchaintest/forwarding_test.go (0 hunks)
• interchaintest/upgrade_grand-1_test.go (1 hunks)
• x/globalfee/ante/fee.go (1 hunks)
• x/globalfee/ante/fee_utils.go (0 hunks)

Files not reviewed due to no reviewable changes (3)

• .changelog/unreleased/features/403-signerless-forwarding.md
• interchaintest/forwarding_test.go
• x/globalfee/ante/fee_utils.go

Additional context used

LanguageTool

CHANGELOG.md

[uncategorized] ~11-~11: Possible missing comma found.
Context: ...cash, 1:1 backed in high-quality liquid assets and is unconditionally redeemable on de...

(AI_HYDRA_LEO_MISSING_COMMA)

---

[grammar] ~19-~19: The word ‘fiat’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
Context: ...ectly check recipient role when trading to fiat. ([#405](https://github.com/noble-asset...

(VB_TO_NN_DT)

Markdownlint

CHANGELOG.md

5-5: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

Additional comments not posted (16)

.changelog/v7.0.0/bug-fixes/405-bump-halo.md (1)

1-1: The changelog entry looks good.

The entry is clear, concise, and properly categorized. It provides a useful summary of the bug fix and links to the relevant pull request for more details.

If possible, please provide more context about the x/halo module and the specific code changes related to this bug fix. This will enable a more thorough review to ensure the fix is implemented correctly and comprehensively.

app/upgrades/numus/store.go (1)

7-7: Verify compatibility of the new florintypes package.

The import path change for the florintypes package is consistent with the PR objective of preparing for the v7.0.0 release. However, it is important to ensure that the new package is a drop-in replacement for the old one and does not introduce any breaking changes or compatibility issues.

Run the following script to verify the compatibility of the new florintypes package:

Verification successful

---

Approve the import change, but recommend thorough testing.

The import path change for the florintypes package has been consistently applied across the codebase. The usage is limited to the ModuleName constant, which suggests a low risk of introducing breaking changes or compatibility issues. However, as we cannot verify the full functionality of the new package in this environment, it's recommended to conduct thorough testing during the integration process.

• The new import path is used consistently in app/app.go and app/upgrades/numus/store.go.
• Usage is limited to florintypes.ModuleName, indicating minimal direct interaction with the package's core functionality.

Please ensure that all tests related to the florin module are executed and pass successfully before merging this change.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the new `florintypes` package is compatible with the old one.

# Test 1: Search for all references to the old `florintypes` package. Expect: No occurrences.
rg --type go -g '!app/upgrades/numus/store.go' $'github.com/noble-assets/florin/x/florin/types'

# Test 2: Search for all references to the new `florintypes` package. Expect: Only occurrences in `app/upgrades/numus/store.go`.
rg --type go -g '!app/upgrades/numus/store.go' $'github.com/monerium/module-noble/x/florin/types'

# Test 3: Search for all usages of types and functions from the `florintypes` package. Expect: No compile errors.
fd --extension go --exec "go build" .

Length of output: 9785

---

Script:

#!/bin/bash
# Investigate the usage of the new florintypes package

# Check the content of app/app.go for the new import
echo "Content of app/app.go related to florintypes:"
sed -n '/florintypes/,/^$/p' app/app.go

# Search for usage of florintypes in app/app.go
echo "Usage of florintypes in app/app.go:"
rg "florintypes\." app/app.go

# Search for usage of florintypes in the entire codebase
echo "Usage of florintypes in the entire codebase:"
rg "florintypes\." --type go

Length of output: 1723

.changelog/v7.0.0/summary.md (1)

1-11: LGTM!

The changelog summary provides a clear and concise overview of the major changes in the v7.0.0 release. The introduction of the x/florin module and the EURe asset is a significant addition to the Noble platform, and the summary provides important context about the issuing entity and the regulatory framework.

The summary is well-structured and easy to understand. Great job!

app/upgrades/numus/upgrade.go (1)

36-37: Changes align with the PR objectives. Verify the specified address.

The changes set the owner and blacklist owner for the Florin module to "noble1ya7ggnwv78qcnkv89lte30yge54ztzst3usgmw" for the mainnet environment, which aligns with the PR objectives.

Note that the same address is being used for both the owner and blacklist owner roles. While this concentrates control to a single entity, it may be an intentional design choice. However, consider reviewing if this aligns with the intended governance model for the Florin module.

Additionally, verify the ownership and control of the specified address to ensure it belongs to the intended entity.

app/ante.go (1)

70-70: LGTM!

The change simplifies the signature verification process by relying solely on the AccountKeeper and SignModeHandler, reducing dependencies on the forwarding module's bank functionalities. This is consistent with the removal of the BankKeeper interface and its associated usage within the HandlerOptions struct and the NewAnteHandler function.

Makefile (1)

126-126: LGTM!

The upgrade of the Protobuf version from 1.39 to 1.40 is a straightforward change that should not introduce any issues. The new version may bring improvements or fixes that are beneficial to the build process.

interchaintest/upgrade_grand-1_test.go (1)

161-161: LGTM! The explicit version tag improves reproducibility.

The change to use ghcrImage("v7.0.0-rc.0") for the "numus" upgrade is a good practice. It makes the version explicit, which improves reproducibility and tracking.

The "v7.0.0-rc.0" tag aligns with the purpose of the "numus" upgrade, which is to introduce the new florin module as part of a major release.

x/globalfee/ante/fee.go (1)

67-67: LGTM!

The change simplifies the criteria for bypassing minimum fees by removing the isSignerlessForwardingRegistration condition. This aligns with the PR objective of supporting signerless account registration in the x/forwarding module.

The change does not introduce any correctness issues or security vulnerabilities. The existing unit tests should cover this scenario.

CHANGELOG.md (3)

3-14: LGTM!

The code segment provides a clear and detailed description of the new x/florin module and the EURe asset. The information is well-structured and easy to understand.

Tools

LanguageTool

[uncategorized] ~11-~11: Possible missing comma found.
Context: ...cash, 1:1 backed in high-quality liquid assets and is unconditionally redeemable on de...

(AI_HYDRA_LEO_MISSING_COMMA)

Markdownlint

5-5: null
Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

---

19-19: LGTM!

The usage of the word "fiat" is correct in this context. It refers to fiat currency, which is a government-issued currency that is not backed by a commodity such as gold.

Tools

LanguageTool

[grammar] ~19-~19: The word ‘fiat’ is not correct in this context. Use one of the suggestions or replace it with an appropriate verb.
Context: ...ectly check recipient role when trading to fiat. ([#405](https://github.com/noble-asset...

(VB_TO_NN_DT)

---

23-23: LGTM!

Updating the module path for the v7 release line is a good practice to ensure proper versioning and avoid conflicts with previous versions.

app/app.go (5)

124-124: LGTM!

The import path change for the florin module is consistent with the AI-generated summary and does not introduce any functional issues.

---

125-125: LGTM!

The import path change for the florin/keeper module is consistent with the change made for the florin module import and does not introduce any functional issues.

---

126-126: LGTM!

The import path change for the florin/types module is consistent with the changes made for the florin and florin/keeper module imports and does not introduce any functional issues.

---

743-743: Verify the BankKeeper usage in the HandlerOptions.

The removal of the BankKeeper field from the HandlerOptions struct initialization is consistent with the AI-generated summary. Ensure that the BankKeeper is directly referenced in the HandlerOptions and that this change streamlines the handling of banking operations within the application.

Run the following script to verify the BankKeeper usage in the HandlerOptions:

---

746-746: Verify the impact of the SigGasConsumer change on transaction processing efficiency.

The change in the SigGasConsumer from forwarding.SigVerificationGasConsumer to ante.DefaultSigVerificationGasConsumer indicates a change in the gas consumption strategy for signature verification. Ensure that this change has a positive impact on transaction processing efficiency and does not introduce any performance regressions.

Run the following script to verify the impact of the SigGasConsumer change on transaction processing efficiency:

Compare the gas consumption logic in the forwarding.SigVerificationGasConsumer and ante.DefaultSigVerificationGasConsumer implementations to ensure that the change has a positive impact on transaction processing efficiency.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.