Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove STAKE supply correction in v8 upgrade #428

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

johnletey
Copy link
Member

No description provided.

@johnletey johnletey self-assigned this Nov 13, 2024
@johnletey johnletey requested a review from a team as a code owner November 13, 2024 14:38
Copy link

coderabbitai bot commented Nov 13, 2024

Walkthrough

The changes in the upgrade/upgrade.go file focus on modifying the CreateUpgradeHandler function by removing the logic for burning surplus staking tokens. This simplifies the upgrade handler, eliminating associated error handling and supply management. The MigrateValidatorAccounts function remains intact, ensuring the migration of validator accounts to locked vesting accounts continues without alteration. The import statements have been updated to reflect the removal of the math package, and overall control flow and logging mechanisms in the upgrade handler remain unchanged.

Changes

File Change Summary
upgrade/upgrade.go - Removed BurnSurplusSupply function.
- Simplified CreateUpgradeHandler by omitting surplus token burning logic.
- Retained MigrateValidatorAccounts function.
- Updated import statements by removing math package.

Poem

🐇 In the land of upgrades, we hop with glee,
Removing the surplus, oh what a spree!
Validators migrate, their tokens secure,
A simpler path forward, of that we’re sure.
With each little change, our code takes flight,
A brighter tomorrow, all feels just right! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d1cb63e and 9a04360.

⛔ Files ignored due to path filters (2)
  • e2e/go.sum is excluded by !**/*.sum, !**/*.sum
  • go.mod is excluded by !**/*.mod
📒 Files selected for processing (1)
  • upgrade/upgrade.go (0 hunks)
💤 Files with no reviewable changes (1)
  • upgrade/upgrade.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@johnletey johnletey enabled auto-merge (squash) November 13, 2024 14:45
@johnletey johnletey disabled auto-merge November 13, 2024 14:45
@johnletey johnletey merged commit 2fe3ec3 into main Nov 13, 2024
37 checks passed
@johnletey johnletey deleted the john/remove-supply-correction branch November 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant