Carouselle #2
Open
Carouselle #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGRibreau
requested changes
Mar 29, 2019
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="stylesheet" href="/assets/css/styles.css?{{site.time | date: '%s%N'}}"> | ||
| <title>{{ site.title }}</title> | ||
| <head> |
There was a problem hiding this comment.
@AugustinRibreau impossible de savoir ce qui a changé dans ce fichier, on ne commit pas un fichier comme cela en entier, ça rend illisible le diff, assure toi que le projet a un prettierrc et qu'il est configuré pour avoir ce même formatting.
@KevinJaffre tu as prettier d'installé sur ta machine ? C'est quoi sa config ? :)
FGRibreau
reviewed
Apr 11, 2019
| } | ||
| }); | ||
|
|
||
| function toggle(id) { |
FGRibreau
reviewed
Apr 11, 2019
| $('.js-toggle-menu').click(function() { | ||
| $('.l-header').toggleClass('is-collapse'); | ||
| $(".js-toggle-menu").click(function() { | ||
| $(".l-header").toggleClass("is-collapse"); |
There was a problem hiding this comment.
No need for jQuery here: https://dommagnifi.co/2016-05-16-basic-class-toggle-with-vanilla-js/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the moment the buttons are functional but all containers are displayed