[TK] Add a TestLaunchContext for generating test dispatch IRs #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groverkss
commented
Feb 12, 2024
| raise ValueError( | ||
| f"Cannot create {type(self)}({', '.join(str(i) for i in dims)}): mismatched symbolic rank" | ||
| ) | ||
| def __init__(self): |
There was a problem hiding this comment.
Instead of passing the grid bindings as inputs, I am now making the grid find out the symbol bindings from the IndexingContext, and if it cannot find a binding for the symbol, it should consider it a workload binding. Currently, this promotion to a workload binding is not implemented and every symbol is assumed to have a constant value.
Groverkss
commented
Feb 12, 2024
| self.rank = rank | ||
| self.rank = len(self.dims) | ||
|
|
||
| def __class_getitem__( |
There was a problem hiding this comment.
This is just to fix a type error. Metaclasses should not have class_getitem on them.
Groverkss
commented
Feb 12, 2024
stellaraccident
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the way we do grid bindings. It is now expected that the IndexingContext will have the workload values and the grid on construction will try to build it's dims using them. Currently, all symbols are assumed to have a constant value, so the grid is able to map workgroup calculations to constants.
Ideally, we would have support to parameterize the kernel by some symbols, which would be passed as workload bindings (We have no support for this currently).