XFAIL failing cpu comparisons #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
force-pushed
the
makslevental/updated-driver
branch
from
c2d99c4
to
1c981a0
Compare
makslevental
force-pushed
the
makslevental/updated-driver
branch
from
1c981a0
to
4b6bc6e
Compare
makslevental
force-pushed
the
makslevental/updated-driver
branch
from
4b6bc6e
to
10dab9e
Compare
makslevental
changed the title
makslevental
force-pushed
the
makslevental/updated-driver
branch
from
41fb0cd
to
2944541
Compare
makslevental
changed the title
makslevental
force-pushed
the
makslevental/updated-driver
branch
from
2944541
to
acacc14
Compare
makslevental
requested review from
MaheshRavishankar,
yzhang93,
Abhishek-Varma and
jtuyls
as code owners
makslevental
force-pushed
the
makslevental/updated-driver
branch
3 times, most recently
from
844c633
to
c788bba
Compare
makslevental
force-pushed
the
makslevental/updated-driver
branch
from
c788bba
to
bccd6f8
Compare
MaheshRavishankar
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows E2E PR #689 is blocked because in order to get Windows to work I had to use a particular commit of XRT (required by XRT-MCDM). At that commit, the current linux driver (date 20240819) fails some tests while the older driver (such as the one on the sharkbox phoenix nuc) passes. I do not know what the exact issue is but even after a couple recent flake-fixes (#697, #694), the disparity persists.
This PR XFAILs (effectively) those tests in order to unblock windows E2E. I will reconcile the disparity shortly.
Tracking issue #700.
cc @newling