Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

gh is --list --milestone 1 Returns error message #703

Closed
josemvidal opened this issue Oct 14, 2019 · 2 comments
Closed

gh is --list --milestone 1 Returns error message #703

josemvidal opened this issue Oct 14, 2019 · 2 comments
Labels
bug released

Comments

@josemvidal
Copy link

josemvidal commented Oct 14, 2019 •
edited
Loading

Version number

> gh --version
gh 2.3.0

Describe the bug
Using the gh is --milestone generates a Validation error:

> gh is --list --milestone 1 
Listing open issues on SCCapstone/sandbox
Error: Error listing issues
HttpError: Validation Failed
    at Object.run (/usr/local/lib/node_modules/gh/lib/cmds/issue.js:135:19)
    at processTicksAndRejections (internal/process/next_tick.js:81:5)

but, other commands work ok:

> gh is --list                                                
Listing open issues on SCCapstone/sandbox
#96 Test gh @josemvidal (an hour ago)


> gh is --list --detailed 
Listing open issues on SCCapstone/sandbox
#96 Test gh @josemvidal (an hour ago)
milestone:  M1 - 25
https://github.com/SCCapstone/sandbox/issues/96

> gh is --list --state closed
Listing closed issues on SCCapstone/sandbox
#95 title @josemvidal (4 days ago)

> gh is --list --labels bug                                                                                       
Listing open issues on SCCapstone/sandbox

No issues on SCCapstone/sandbox

> gh is 'Node GH rocks!' 'Body with **Markdown** support'                          

Creating a new issue on SCCapstone/sandbox
https://github.com/SCCapstone/sandbox/issues/97
[hook] gh is --browser  --user SCCapstone --repo sandbox --number 97

So, it seems to be a problem with the --milestone only.

To Reproduce

gh is --list --milestone 1

Expected behavior

List of Issues associated with Milestone 1.
@josemvidal josemvidal added the bug label Oct 14, 2019
@protoEvangelion
Copy link
Member

Thanks for reporting @josemvidal I will take a look 👍

protoEvangelion pushed a commit to protoEvangelion/gh that referenced this issue Oct 16, 2019
fix(issue): log proper message when filtering issues by milestone
4e9d6a3 
In the case where we can't find the milestone we should log a helpful message
and bail before trying to list the issues.

fix node-gh#703
protoEvangelion pushed a commit that referenced this issue Oct 16, 2019
@semantic-release-bot
chore(release): 2.3.1 [skip ci]
e524893 
## [2.3.1](v2.3.0...v2.3.1) (2019-10-16)

### Bug Fixes

* **issue:** log proper message when filtering issues by milestone ([5cb1231](5cb1231)), closes [#703](#703)
@protoEvangelion
Copy link
Member

🎉 This issue has been resolved in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josemvidal @protoEvangelion