Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Add setting option to not open editor when title or msg blank #719

Closed
protoEvangelion opened this issue Nov 5, 2019 · 1 comment
Closed

Add setting option to not open editor when title or msg blank #719

protoEvangelion opened this issue Nov 5, 2019 · 1 comment

Comments

@protoEvangelion
Copy link
Member

RE #717

Add config option like open_editor: false which defaults to true.

This will enable a user in CI mode to not have their editor opened when leaving a title or msg blank.
protoEvangelion pushed a commit to protoEvangelion/gh that referenced this issue Nov 5, 2019
feat(pull-request): do not open editor when user has use_editor set t…
5ba0789 
…o false

Especially useful for user in CI context and they have no control over their editor being
opened or not.

re node-gh#719
protoEvangelion pushed a commit that referenced this issue Nov 5, 2019
feat(pull-request): do not open editor when user has use_editor set t…
9e810c4 
…o false

Especially useful for user in CI context and they have no control over their editor being
opened or not.

re #719
protoEvangelion pushed a commit that referenced this issue Nov 5, 2019
@semantic-release-bot
chore(release): 2.5.0 [skip ci]
4494860 
# [2.5.0](v2.4.1...v2.5.0) (2019-11-05)

### Features

* **issue:** dont open editor when use_editor is false ([be7e5b0](be7e5b0))
* **pull-request:** do not open editor when user has use_editor set to false ([9e810c4](9e810c4)), closes [#719](#719)
@protoEvangelion
Copy link
Member Author

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@protoEvangelion