Record sample timestamps

node-inspector · Aug 31, 2015 · 49461b2 · 49461b2
1 parent 372fb46
commit 49461b2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/cpu_profile.cc b/src/cpu_profile.cc
@@ -87,15 +87,18 @@ namespace nodex {
     Local<Value> start_time = Nan::New<Number>(node->GetStartTime()/1000000);
     Local<Value> end_time = Nan::New<Number>(node->GetEndTime()/1000000);
     Local<Array> samples = Nan::New<Array>();
+    Local<Array> timestamps = Nan::New<Array>();
 
     uint32_t count = node->GetSamplesCount();
     for (uint32_t index = 0; index < count; ++index) {
       samples->Set(index, Nan::New<Integer>(node->GetSample(index)->GetNodeId()));
+      timestamps->Set(index, Nan::New<Number>(static_cast<double>(node->GetSampleTimestamp(index))));
     }
 
-    profile->Set(Nan::New<String>("startTime").ToLocalChecked(), start_time);
-    profile->Set(Nan::New<String>("endTime").ToLocalChecked(),   end_time);
-    profile->Set(Nan::New<String>("samples").ToLocalChecked(),   samples);
+    profile->Set(Nan::New<String>("startTime").ToLocalChecked(),   start_time);
+    profile->Set(Nan::New<String>("endTime").ToLocalChecked(),     end_time);
+    profile->Set(Nan::New<String>("samples").ToLocalChecked(),     samples);
+    profile->Set(Nan::New<String>("timestamps").ToLocalChecked(),  timestamps);
 #endif
 
     Local<Array> profiles = Nan::New<Array>(Profile::profiles);

diff --git a/test/cpu_cprofiler.js b/test/cpu_cprofiler.js
@@ -81,7 +81,7 @@ describe('CPU', function() {
       var profile = binding.cpu.stopProfiling();
       var properties = NODE_V_10 ?
         ['delete', 'typeId', 'uid', 'title', 'head'] :
-        ['delete', 'typeId', 'uid', 'title', 'head', 'startTime', 'endTime', 'samples'];
+        ['delete', 'typeId', 'uid', 'title', 'head', 'startTime', 'endTime', 'samples', 'timestamps'];
 
       properties.forEach(function(prop) {
         expect(profile).to.have.property(prop);