forked from bnb-chain/bsc
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remoteDb only delay syncs for specified peers #130
Open
asyukii
wants to merge
65
commits into
node-real:state_expiry_mvp0.1_dev
Choose a base branch
from
asyukii:state_expiry_mvp0.1_delay_sync
base: state_expiry_mvp0.1_dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: remoteDb only delay syncs for specified peers #130
asyukii
wants to merge
65
commits into
node-real:state_expiry_mvp0.1_dev
from
asyukii:state_expiry_mvp0.1_delay_sync
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: verify proof first then only revive remove comments edit function comments verify child hash while constructing trie from proof remove unnecessary comments and parameters
state/statedb: support state expiry; state/state_object: add revive trie, access state, etc.;
fix minor test bug
minor fix change rpc blockNum to hash
state/statedb: fetch expired state from remote;
minor change to key remove journal codes
apply comments
trie/epochmeta: trie integrate epoch meta storage;
ethdb/fullstatedb: support proof cache; trie/epochmeta: opt query & commit logic; bugfix: fix remote full state db params;
more fixes minor
bugfix: fix state copy issues, remote cache;
more fixes Squashed commit of the following: commit 45e7deacede8ebecd2625cc09c609d0b92f96515 Author: 0xbundler <124862913+0xbundler@users.noreply.github.com> Date: Mon Sep 4 11:50:49 2023 +0800 trie/proof: fix child hash validate bug; bugfix: fix state copy issues, remote cache;
trie: commit account meta, revive state bug; ethdb/fullstatedb: fix cache bug, cannot share by key;
pruner: fix some epoch meta db error; metrics: add more metrics for state expiry;
fullstatedb: opt storage trie init method; metrics: add more cost time metrics;
pruner: refactor expired prune;
trie/trie: fix some migrate issues; trie: fix compile error;
remove log
trie/inspect: opt inspect in PBSS mode;
add server related for snap sync edit
trie/trie: fix some update epoch bugs; state/state_object: fix epoch update issue; state/statedb: fix oom issue;
trie: fix rebase error;
trie/trie: merge epoch meta & trie store in PBSS;
trie/trie: reuse node cache, prevent resolve again;
pruner: opt concurrent logic; state/state_object: add access state in prefetch;
state/state_object: add more expired metrics;
trie: fix local review leaf expand bug;
trie: support revive from prefix;
lint: fix some golang lint;
asyukii
force-pushed
the
state_expiry_mvp0.1_delay_sync
branch
from
November 6, 2023 07:52
364a2eb
to
68a24ca
Compare
0xbundler
force-pushed
the
state_expiry_mvp0.1_dev
branch
from
November 27, 2023 08:49
128eb98
to
1c75ad6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RemoteDB will check if the peer request is from a specified peer before delaying its sync.
Rationale
RemoteDB shouldn't delay sync for peers that it doesn't care about, since the primary purpose of delaying sync is to provide suitable proof for a particular state expiry enabled node.
Changes
StateExpiryAllowedNodes
toNode.P2P
configShouldKeep1EpochBehind
now checks for peerID