Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to override default authnRequestBinding when using MultiSamlStrategy #528

Closed
mhesler74 opened this issue Feb 1, 2021 · 6 comments · Fixed by #529
Closed
Labels

Comments

@mhesler74
Copy link
Contributor

passport.authenticate only uses the default authnRequestBinding setting when using the MultiSamlStrategy class.
Providing an alternative authnRequestBinding setting as a return value in the getSamlOptions function is completely ignored.

@mhesler74 mhesler74 added the bug label Feb 1, 2021
@cjbarth
Copy link
Collaborator

cjbarth commented Feb 1, 2021

Would you be willing to make a PR to address this @mhesler74 ?

@stavros-wb
Copy link
Contributor

It's currently a "global" passport configuration

authnRequestBinding: 'HTTP-POST',

Do you need it, to be set per client?

@mhesler74
Copy link
Contributor Author

Yes, I need it set per client. Some of our customers are using HTTP-Request binding for authentication while others support HTTP-POST.

@mhesler74
Copy link
Contributor Author

Actually another PR was put in a while back by someone else... very similar
#432

@cjbarth cjbarth linked a pull request Feb 15, 2021 that will close this issue
@mhesler74
Copy link
Contributor Author

Any ETA on when this will be included in a release?

@cjbarth
Copy link
Collaborator

cjbarth commented May 10, 2021

I believe this is part of the v3 release, which is held up due to some missing code reviews. See https://github.com/node-saml/passport-saml/milestone/1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants