Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the authnRequestBinding option per IdP in the MultiSamlStrategy #432

Closed
wants to merge 2 commits into from

Conversation

bradydoll
Copy link

Currently the authnRequestBinding configuration applies to all Identity Providers when using the MultiSamlStrategy.

This moves the option from the Strategy object to the SAML object so the getSamlOptions function from the MultiSamlStrategy can override it per Identity Provider.

@brodly
Copy link

brodly commented Dec 9, 2020

@bradydoll wondering if you could fix the conflicts here and push. just discovered this issue myself and looks like you have the same solution as me

@cjbarth
Copy link
Collaborator

cjbarth commented Dec 15, 2020

This makes sense, however, there is a merge conflict. Can you resolve them?

@bradydoll
Copy link
Author

I hope to have some time over the next week to fix the merge conflicts.

@bradydoll
Copy link
Author

I finally got a chance to resolve these.

@cjbarth
Copy link
Collaborator

cjbarth commented Feb 15, 2021

@bradydoll @bradydoll , could you please have a look at #529 and see if that addresses this PR. If so, can we close this in favor of that PR?

@cjbarth cjbarth closed this Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants