docs(scoping): fix for example #504
Conversation
README.md
Outdated
| name: 'yourName', // optional | ||
| loc: 'yourLoc', // optional | ||
| } | ||
| idpList: [ // required |
There was a problem hiding this comment.
Is idpList really required now? If so, I think that may have been a breaking change that we didn't properly account for.
There was a problem hiding this comment.
@cjbarth My mistake.
The idpList isn't required as stated in the saml2.0 spec. It actually wasn't required in the previously added feature either as can be seen in /src/passport-saml/saml/ts:361.
The only mismatch was in the Typescript interface SamlScopingConfig. I reverted the required to optional in the documentation and fixed the Typescript interface in my latest commit.
rob-gijsens
force-pushed
the
docs/scoping-option-fix
branch
from
1897051
to
c42a8c9
Compare
|
@cjbarth Thanks for approving. What is next in the PR process? I don't have write access to this repository to merge this PR myself, and also haven't the right authorization to assign someone who does. Is this automatically being merged when a next release is made? |
Fix in the README example of the scoping option which I previously added in a different PR.