Reexport SamlConfig type to solve a regression in consumer packages #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quite similar to #476
Maintainers of the @types/passport-saml package exported the
SamlConfigtype: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/passport-saml/index.d.ts#L39Passport-SAML-Metadata (https://github.com/compwright/passport-saml-metadata) which depends on this package@latest and, more importantly, its types were referring to that interface.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/passport-saml-metadata/src/metadata.d.ts
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/passport-saml-metadata/src/passport.d.ts
(Never mind my own code using this interface for convenience reasons as well.)
Re-Exporting the
SamlConfiginterface will resolve TypeScript compilation issues.Checklist:
This really is [BUG] No exported member #475 all over again.
(I didn't plug in any, as TSC was ignoring the
testfolder, but if you feel this should be solved sooner rather than later)