Skip to content

Commit

Permalink
Create GitHub Actions workflow for CI
Browse files Browse the repository at this point in the history
Drop node 5 for node 6, as the former appears to not
run at all on GitHub Actions

Works towards #250
  • Loading branch information
LoneRifle committed Jul 24, 2022
1 parent ce2f4e6 commit 91dd3d5
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Continuous Integration
on:
push:
pull_request:
types: [opened, reopened]

jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
version: [4, 6]

This comment has been minimized.

Copy link
@cjbarth

cjbarth Jul 24, 2022

Contributor

Are you saying that you don't want to have the tests run on the latest Node versions? I understand wanting to support Node v4 for certain clients (though they should really upgrade since their version isn't supported anymore), but wouldn't we want to know if there is a compatibility issue with newer version that are still supported?

This comment has been minimized.

Copy link
@LoneRifle

LoneRifle Jul 25, 2022

Author Collaborator

Thanks for the catch! I was faithfully reproducing what Travis used to do, but will add to the matrix so we run on later versions.

steps:
- uses: actions/checkout@HEAD
- uses: actions/setup-node@HEAD
with:
node-version: ${{ matrix.version }}
- run: npm install
- run: npm test

0 comments on commit 91dd3d5

Please sign in to comment.