Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suites of other projects (mocha) that include v1.5.0 fail #207

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Test suites of other projects (mocha) that include v1.5.0 fail #207

merged 2 commits into from
Apr 13, 2020

Conversation

troyfactor4
Copy link
Contributor

@troyfactor4 troyfactor4 commented Apr 12, 2020 •
edited
Loading

Error message: "Error: global leak detected: existingPrefixes"
Test was run using project 'samlp' from npmjs.org with xml-crypto updated to 1.5.0

Steps to reproduce:

  1. git clone https://github.com/auth0/node-samlp.git
  2. Modify package.json and update xml-crypto to 1.5.0
  3. npm install
  4. npm test

@troyfactor4
Copy link
Contributor Author

I can make these two separate PR if needed.

LoneRifle
LoneRifle approved these changes Apr 13, 2020
View reviewed changes
Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - i'll have a release out

@LoneRifle LoneRifle merged commit 07e2320 into node-saml:master Apr 13, 2020
@cjbarth cjbarth added the bug label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@troyfactor4 @LoneRifle @cjbarth