Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linting #287

Merged
merged 3 commits into from
May 30, 2023
Merged

Add support for linting #287

merged 3 commits into from
May 30, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented May 29, 2023

This PR will add support for linting the code, but doesn't turn it on as part of the CI build. After this lands, another PR will land with all the code linted and the linting check turned on as part for the CI build.

@cjbarth cjbarth added the chore label May 29, 2023
@cjbarth cjbarth requested a review from LoneRifle May 29, 2023 16:28
LoneRifle
LoneRifle previously approved these changes May 29, 2023
Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

.eslintignore Outdated Show resolved Hide resolved
.eslintrc.json Show resolved Hide resolved
Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjbarth cjbarth merged commit f9657b5 into master May 30, 2023
@cjbarth cjbarth deleted the quality-of-life branch May 30, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants