Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format code #289

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Format code #289

merged 2 commits into from
Jun 1, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented May 31, 2023

This is a collection of automatic code format changes from running npm run prettier-format. There are just a few changes in example.js and README.md that were manual (to disable rules and add code fences).

@cjbarth cjbarth requested a review from LoneRifle May 31, 2023 14:24
@cjbarth
Copy link
Contributor Author

cjbarth commented May 31, 2023

I would eventually like to update the lint rules to be something like the following because the current code mixes many different styles:

{
  "env": {
    "node": true,
    "mocha": true,
    "es6": false
  },
  "root": true,
  "parserOptions": {
    "ecmaVersion": 6
  },
  "extends": ["eslint:recommended", "prettier"],
  "rules": {
    "no-console": "error",
    "no-unused-vars": "warn",
    "no-prototype-builtins": "warn",
    "one-var": ["warn", "never"],
    "no-duplicate-imports": "error",
    "no-use-before-define": "error",
    "curly": "warn",
    "eqeqeq": ["error", "smart"],
    "no-var": "warn",
    "prefer-const":"warn"
  }
}

After this lands, I'll put up a PR for that so that we can properly discuss.

Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; linting-related changes, I'm assuming no logic change. Relying on unit tests (which themselves have changed) to ensure correctness

@cjbarth cjbarth merged commit ca56346 into node-saml:master Jun 1, 2023
@cjbarth cjbarth added the chore label Jun 1, 2023
@cjbarth cjbarth deleted the format branch June 8, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants