Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust references for node-saml organization #298

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Jun 6, 2023

The README badge was pointing to the wrong location and the NPM package name was scoped, which it doesn't seem like we're using yet. We should discuss if we want to move this NPM package to be a scopped one and deprecate the unscopped version. For now, we have to unscope it so that we can do a release.

@cjbarth
Copy link
Contributor Author

cjbarth commented Jun 6, 2023

@LoneRifle @markstos , I'd like to hear your thoughts on scopped vs. unscopped for this package.

@cjbarth cjbarth merged commit 85353a8 into node-saml:master Jun 6, 2023
@markstos
Copy link

markstos commented Jun 6, 2023

As long it as we are compatible with the unscoped NPM package and it's not causing other problems, I would keep using it.

In otherwords: Let's stay backwards compatible with what most people are using unless there's a compelling reason not to be.

@cjbarth cjbarth deleted the scope-fix branch June 8, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants