Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target an LTS version of Node #299

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Jun 6, 2023

This is a semver-major change that will bring the dependencies up to supported versions and more easily allow migration of tests to supported test frameworks.

@cjbarth
Copy link
Contributor Author

cjbarth commented Jun 6, 2023

This will use lts/*, lts/-1 and lts/-2, but will do so via [14, 16, 18], which allows us to update package.json's engine as we move forward. This also tests latest, so we make sure that we see any coming issues as node is upgraded.

@cjbarth cjbarth merged commit d2e9ba1 into node-saml:master Jun 6, 2023
@cjbarth cjbarth deleted the bump-node branch June 6, 2023 15:31
@parallels999
Copy link
Contributor

Hi, when will there be a new release with these changes?

@cjbarth
Copy link
Contributor Author

cjbarth commented Jul 6, 2023

As soon as we finish the TS conversion... which is dependent on goto100/xpath#116 landing. We're getting close. FWIW, this release is holding up the v5 release of passport-saml and node-saml, so there is strong motivation to get this along.

@parallels999
Copy link
Contributor

parallels999 commented Jul 6, 2023

@cjbarth so, is possible #333 Bump @xmldom/xmldom to 0.8.8 for V3?

Example node-saml:
https://github.com/node-saml/node-saml/blob/9657c6663a44d856684ac96beb5b887c1a2311f6/package.json#L62
https://github.com/node-saml/node-saml/blob/9657c6663a44d856684ac96beb5b887c1a2311f6/package.json#L64
node-saml requires "xml-crypto": "^3.1.0", "@xmldom/xmldom": "^0.8.8"
but xml-crypto v3.1.0 requires "@xmldom/xmldom": "0.8.7"

@cjbarth
Copy link
Contributor Author

cjbarth commented Jul 6, 2023

Sure, just make a PR against master, we'll land it, and then make the same thing against 3.x.

@parallels999
Copy link
Contributor

parallels999 commented Jul 6, 2023

that's the point, master already has this change, ON THIS PR, this is missing in 3.x

"@xmldom/xmldom": "^0.8.8",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants