Rename signingCert -> publicCert and signingKey -> privateKey
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
=======================================
Coverage 82.74% 82.74%
=======================================
Files 5 5
Lines 875 875
=======================================
Hits 724 724
Misses 151 151
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LoneRifle
requested changes
Jun 18, 2023
.../validators/XmlCryptoUtilities/XmlCryptoUtilities/program-repro-misc-validation-and-canon.cs
Outdated
Show resolved
Hide resolved
test/validators/XmlCryptoUtilities/XmlCryptoUtilities/utilities.cs
Outdated
Show resolved
Hide resolved
|
It certainly was built on the .Net mode, but, I think we'd all agree, no one praises the .Net model for its simplicity. What is more, it seems like the interface really hides a lot of complexity under the hood; complexity that we just don't have the resources to develop or maintain. I think I'm happy with the direction we've taken this and I think it gives us room to move forward with the kinds of use-cases that those using this project are encountering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.