Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce eslint no-prototype-builtins #321

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Jun 23, 2023

No description provided.

@cjbarth cjbarth added the chore label Jun 23, 2023
@cjbarth cjbarth requested a review from LoneRifle June 23, 2023 08:49
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #321 (b3e5ecd) into master (bba9f7c) will increase coverage by 0.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   81.56%   82.49%   +0.93%     
==========================================
  Files           7        7              
  Lines         819      777      -42     
==========================================
- Hits          668      641      -27     
+ Misses        151      136      -15     
Impacted Files Coverage Δ
lib/c14n-canonicalization.js 64.15% <100.00%> (-0.51%) ⬇️
lib/enveloped-signature.js 100.00% <100.00%> (+5.00%) ⬆️
lib/exclusive-canonicalization.js 86.44% <100.00%> (+0.95%) ⬆️
lib/signed-xml.js 89.16% <100.00%> (+1.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cjbarth cjbarth merged commit 4040b6a into node-saml:master Jun 25, 2023
@cjbarth cjbarth deleted the no-prototype-builtins branch June 25, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants