Expand the options, move idmode into options, fix types #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2023 23:48
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
=======================================
Coverage 82.49% 82.49%
=======================================
Files 7 7
Lines 777 777
=======================================
Hits 641 641
Misses 136 136
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cjbarth
reviewed
Jun 27, 2023
cjbarth
previously approved these changes
Jun 27, 2023
|
@shunkica , I'm not sure why this is a draft PR, but it looks good so far. Thanks! |
added 2 commits
June 27, 2023 17:00
added 2 commits
June 27, 2023 17:10
I wanted to have another read through the readme before submitting. |
cjbarth
reviewed
Jun 27, 2023
cjbarth
previously approved these changes
Jun 27, 2023
Co-authored-by: Chris Barth <chrisjbarth@hotmail.com>
|
@cjbarth go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the SignedXml class to accept all options through a single options object, enhancing the flexibility and readability of the code. This change includes migrating the idMode argument into the options object for better consistency.
Also fixed some broken types, and updated README to be consistent with these changes.