Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exported typings #367

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Improve exported typings #367

merged 1 commit into from
Jul 27, 2023

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Jul 27, 2023

The exported types were adjusted to make them more extensible and in line with convention. They were also tweaked for accuracy.

@cjbarth cjbarth added the chore label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #367 (6376b4b) into master (a05732d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   72.14%   72.14%           
=======================================
  Files           9        9           
  Lines         858      858           
  Branches      227      227           
=======================================
  Hits          619      619           
  Misses        138      138           
  Partials      101      101           
Files Changed Coverage Δ
src/types.ts 50.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth cjbarth merged commit be61682 into node-saml:master Jul 27, 2023
9 checks passed
@cjbarth cjbarth deleted the types-export branch July 27, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant